[ http://jira.magnolia-cms.com/browse/MAGNOLIA-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roman Kovař�k updated MAGNOLIA-4513: ------------------------------------ Comment: was deleted (was: MAGNOLIA-4513 debug log readability when adding ACL) > Implement toString() on info.magnolia.cms.security.ACLImpl for log readability > ------------------------------------------------------------------------------ > > Key: MAGNOLIA-4513 > URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-4513 > Project: Magnolia > Issue Type: Bug > Security Level: Public > Components: core > Affects Versions: 4.5.4 > Reporter: Grégory Joseph > Assignee: Roman Kovař�k > Priority: Trivial > Fix For: 4.5.5 > > > Debug logs are filled with lines like this one: > {noformat}2012-08-15 17:03:05,016 DEBUG > info.magnolia.jaas.sp.jcr.JCRAuthorizationModule : ACL: > info.magnolia.cms.security.ACLImpl@59b5b945{noformat} > This is quite meaningless. Two simple suggestions: > 1) log the username (yes, it's log a few lines above, but if two users log in > at the same time, you're lost) > 2) implement {{toString()}} on {{info.magnolia.cms.security.ACLImpl}} so that > this becomes useful. Since {{info.magnolia.cms.security.PermissionImpl}} > already has a {{toString()}}, it should be straightforward - print out the > name and the list of permissions of the ACL. > Additionally, you might want to make the log message a little more meaningful > - i.e saying what's happening with that ACL (something like "adding ACL to > user {}: {}" I guess?) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com> ----------------------------------------------------------------