info.magnolia.module.blossom.template.TemplateDefinitionBuilder#resolveTemplateId
 throws IllegalStateException (with empty error string) when class is missing 
Template annotation
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: BLOSSOM-101
                 URL: http://jira.magnolia-cms.com/browse/BLOSSOM-101
             Project: Magnolia Blossom Module
          Issue Type: Improvement
    Affects Versions: 2.0.1
            Reporter: Tomas Brimor
            Assignee: Tobias Mattsson


info.magnolia.module.blossom.template.TemplateDefinitionBuilder#resolveTemplateId
 throws IllegalStateException when class is missing Template annotation. 

- Why no error message? Looking at the code its seems very clear what the 
problem is, the error should communicate this?

- I'm not sure the IllegalStateException is the best exception? Its description 
reads "Signals that a method has been invoked at an illegal or inappropriate 
time." A missing annotation is not really an issue regarding the timing of this 
call? Without the null check the actual exception would have been a 
NullPointerException, maybe catch that and re-throw it with an message 
explaining why it happened (related to the missing error message).


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------

Reply via email to