[ http://jira.magnolia-cms.com/browse/MGNLUI-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Haderka reopened MGNLUI-111: -------------------------------- - AppBuilder {noformat} public SubAppBuilder subApp(String name) { + ConfiguredContentSubAppDescriptor subAppDescriptor = new ConfiguredContentSubAppDescriptor(); {noformat} -- does that mean we support only content app descriptors from AppBuilder? -- Why is AppBuilder part of contacts app? Is it only ContactsAppBuilder rather then generic one? If so, it needs to be renamed. - ContentAppBuilder -- what is the difference between AppBuilder and ContentAppBuilder now that both use *Content*? -- Why is it in contacts package? If it is not generic, it needs to be renamed to ContactContentAppBuilder - SubAppBuilder {noformat} - public SubAppBuilder(ConfiguredSubAppDescriptor descriptor) { + public SubAppBuilder(ConfiguredContentSubAppDescriptor descriptor) { {noformat} -- it is now just ContentSubAppBuilder and if it is not generic it needs to be renamed to ContactsSubAppBuilder. If it is generic, in needs to be moved out of contacts app module. - AppContext {noformat} /** * * @param location */ {noformat} -- This kind of javadoc is totally useless. If you don't plan to write any javadoc, don't leave this in the code. > workbench definition part of subapp descriptor, not app descriptor > ------------------------------------------------------------------ > > Key: MGNLUI-111 > URL: http://jira.magnolia-cms.com/browse/MGNLUI-111 > Project: Magnolia UI > Issue Type: Task > Security Level: Public > Affects Versions: 5.0 Alpha1 s007 > Reporter: Espen Jervidalo > Assignee: Espen Jervidalo > Fix For: 5.0 Alpha1 s009 > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com> ----------------------------------------------------------------