![]() |
|
|
|
|
Change By:
|
Roman Kovařík
(06/Mar/14 10:48 AM)
|
|
Comment:
|
git commit -m "MGNLUI-2730 retrieve String value instead of casting"
* {{/home/romankovarik/projects/master/rssaggregator/src/main/java/info/magnolia/module/rssaggregator/setup/FeedReferenceMigrationTask.java:57: First sentence should end with a period.}}
* failing tests:
{code}
Failed tests: testUpdateTo22ReordersRSSBeforeConfigApp(info.magnolia.module.RSSAggregatorVersionHandlerTest): Unable to perform Migration task Migrate Hackergotchi user pics
testUpdateFrom21(info.magnolia.module.RSSAggregatorVersionHandlerTest): Unable to perform Migration task Migrate Hackergotchi user pics
testUpdateFromMagnolia45x(info.magnolia.module.RSSAggregatorVersionHandlerTest): Unable to perform Migration task Migrate Hackergotchi user pics
Tests in error:
testFeedSubscriptionIsProperlyExposed(info.magnolia.module.rssaggregator.templates.components.FeedSubscriptionModelTest)
{code}
* no need to define a constant for "mgnl:template" (use Renderable.TEMPLATE)
* Please wrap addTask() to next line as usual:
{{register(DeltaBuilder.update("2.2.3", "").addTask(new feedReferenceMigrationTask()));}}
* Don't catch NPE, check for null:
{code}
try {
Node referencedNode = SessionUtil.getNodeByIdentifier(RSSAggregatorConstants.WORKSPACE, feedReference);
node.setProperty(propertyName, referencedNode.getPath());
} catch (NullPointerException e) {
{code}
* Version handler test:
** is named {{testSamplePageUpdateFromMagnolia45x}}, but actually test update from {{2.2.1}}. Should be probably update from {{2.2.2}} :-D.
** {{MgnlContext.getJCRSession("data");}} is not used.
** {{assertTrue(node.getProperty("feed").getString().equals(""));}} use assertEquals
* FeedSubscriptionModelTest:
{{assert result.iterator().next().get("author") != null;}} Use {{assertNotNull}}.
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------
