[magnolia-dev] [JIRA] (MGNLCACHE-57) Avoid unnecessary cache locking for uncacheable entries

[on behalf of Roman Kovařík]

Roman Kovařík reopened MGNLCACHE-57 Avoid unnecessary cache locking for uncacheable entries We’re not 100% convinced by isCacheableVoters’s default “AND” op, and the needed for checking getVoters().length == 0 - i.e we see why you had to do it, but this is yet another thing we don’t like about the whole voting API. The commit to CacheModuleVersionHandler is “full" of codestyle changes. Please avoid. HasVariantVoter needs javadoc HasVariantVoter is not-ed in config - maybe it’s easier to read if it’s positive ? WDYT about rename to IsCacheable (in the p13n packages) and avoid the “not” ? HasVariantVoter extends AbstractBoolVoter<Object> -> should be typed This lead us to see that the passed value (CachedEntry) is actually not used by voter maybe these Voters could vote on AggregationState instead of CacheEntry ? if not, then when using Provider<AggState>, name it aggstateProvider (injected at different scope) PersonalizationIntegrationModuleVersionHandler : avoid bootstrap file for 2-properties node of isNotVariant, use NodeBuilder or simple tasks instead. Change By: Roman Kovařík (29/Oct/14 8:41 AM) Resolution: Fixed Status: Resolved Reopened

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

---

----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------