[magnolia-dev] [JIRA] (MGNLSITE-38) Provide in SiteFunctions: Nested call to get theme

[JIRA (on behalf of Christian Ringele)]

Title: Message Title

Christian Ringele created an issue   Magnolia Site Module / MGNLSITE-38 Provide in SiteFunctions: Nested call to get theme Issue Type: Improvement Assignee: Unassigned Created: 15/Sep/15 2:05 PM Priority: Neutral Reporter: Christian Ringele When you need the current configured theme you need to retrieve it with two calls: [#assign currentSite = sitefn.site(content)] [#assign currentTheme = sitefn.theme(currentSite)] //Clear, you can also do it in one line of code, but its still two calls: [#assign currentTheme = sitefn.theme(sitefn.site(content)))] Which is a bit confusing for beginners. And also its more error prone and less straight forward. It would be easy to provide it in one method fir getting the theme accepting Node, doing the nested call: [#assign currentTheme = sitefn.theme(content)] Would look like this: public Theme theme(Node content) { if(content == null) return null; Site site = this.site(content); return (site == null) ? null : this.theme(site); } I included a patch containing the code, and also a version for ContentMap. Also I added some missing null handling in the 'getTheme(Node content)' Add Comment   This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) ---------------------------------------------------------------- For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com> ----------------------------------------------------------------