[magnolia-dev] [JIRA] (MGNLUI-3590) Get rid of TODO: Let the customer decide who can archive tasks and don't hardcode it ('superuser' role)!

[JIRA (on behalf of Christian Ringele)]

Title: Message Title

Christian Ringele created an issue   Magnolia UI / MGNLUI-3590 Get rid of TODO: Let the customer decide who can archive tasks and don't hardcode it ('superuser' role)! Issue Type: Bug Affects Versions: 5.4.2, 5.3.10 Assignee: Unassigned Components: pulse Created: 16/Sep/15 1:11 PM Labels: support Priority: Neutral Reporter: Christian Ringele Security Level: Public Tasks which are resolved can only be achieved by users with 'superuser' role. But this does not fit reality in projects... The customer needs to be able to decide, who can archive successful pulse tasks. It is a 'no go' to give somebody complete superuser rights just to be able to archive pulse tasks. A valid situation would be: Let also publishers archive their tasks. Or, let a explicit role archive tasks. In 5.4.x its line 143 in info.magnolia.ui.admincentral.shellapp.pulse.item.list.PulseListFooter: User user = MgnlContext.getUser(); // TODO ideally context menu action availability should use the same mechanism and rules defined in the messageView config // but as this is not straightforward, for the time being we hack it like this if (user.getAllRoles().contains("superuser")) { addRemoveMenuItem(i18n, itemsTable, contextMenu, "pages.publish.actions.archive"); } In 5.3.x its line 153 in info.magnolia.ui.admincentral.shellapp.pulse.item.list.PulseListFooter: User user = MgnlContext.getUser(); // TODO ideally context menu action availability should use the same mechanism and rules defined in the messageView config // but as this is not straightforward, for the time being we hack it like this if (user.getAllRoles().contains("superuser")) { addRemoveMenuItem(i18n, itemsTable, contextMenu, "pages.publish.actions.archive"); } In my opinion, a implementation like this is exactly what the comment says: "we hack it like this"... Add Comment   This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) ---------------------------------------------------------------- For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com> ----------------------------------------------------------------