[ http://jira.magnolia.info/browse/MAGNOLIA-1461?page=comments#action_13882 ] Fabrizio Giustina commented on MAGNOLIA-1461: ---------------------------------------------
> Fabrizio, it seems to me that adding the exclusions in the > <dependencyManagement> is enough, isnt that the case? unfortunately that is usually not enough in a multiproject build :/ for example if you exclude commons-logging from commons-betwixt in dependencyManagement the result is that the dependency gets removed from magnolia-core. However this exclusion only applies to magnolia-core and it's not transitive: only exclusions declared directly in the pom seems to be transitive. Because of that and since the "magnolia" module (the main webapp) depends on magnolia-core, the exclusion is not carried over and commons logging still pops up in the final war. I didn't tested this properly after the upgrade to maven 2.0.6, but I guess that the changes in dependency management didn't affect this behaviour. At least I am sure that dependencies still show up in the maven generated dependency report but maybe a second check to WEB-INF/lib could confirm this... > Remove commons-logging > ---------------------- > > Key: MAGNOLIA-1461 > URL: http://jira.magnolia.info/browse/MAGNOLIA-1461 > Project: Magnolia > Issue Type: Task > Components: deployment > Reporter: Grégory Joseph > Assigned To: Fabrizio Giustina > Fix For: 3.1 > > > As far as I can tell, none of the magnolia code is using commons-logging > anymore. We should be able to remove it from our main build. (it will > probably still come up through transitive dependencies, so we need to check > if the versions are compatible) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://www.magnolia.info/en/developer.html ----------------------------------------------------------------
