[ http://jira.magnolia.info/browse/MAGNOLIA-1512?page=all ]

Grégory Joseph resolved MAGNOLIA-1512.
--------------------------------------

    Resolution: Fixed

fixed: not overriding the request encoding if already set. however, the 
<input type="hidden" name="_charset_" /> field does not make the browser send 
an encoding charset within the request headers like i thought it would. All it 
does it set the value of that field to the encoding used in the page. Since 
this is very hacky, Id rather not implement support for it in the main magnolia 
code. If someone really needed this, they could override the 
setupContentTypeAndCharacterEncoding of ContentTypeFilter.

> Request charset should be set before any req.getParameter call
> --------------------------------------------------------------
>
>                 Key: MAGNOLIA-1512
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-1512
>             Project: Magnolia
>          Issue Type: New Feature
>          Components: core
>            Reporter: Grégory Joseph
>         Assigned To: Grégory Joseph
>             Fix For: 3.1 M2
>
>
> At the moment, the request charset is set using Aggregator.getExtension(), 
> which in turns uses Context.getAttribute. Since the WebContextImpl 
> implementation of getAttribute calls getParameter in case the attribute does 
> not exist on the request, thus making the setCharacterSet call useless - and 
> preventing parameters to be parsed properly (indeed, the container will parse 
> them on the first call to getParam*() with a default encoding - iso-8859-1 in 
> the case of tomcat) 
> We might solve this by making the Aggregator.getExtension method (and 
> associated) just using the context attribute - which have to be set 
> previously, for instance by a new filter that has yet to be created.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------

Reply via email to