Hi Amir,
On Dec 12, 2007, at 19:57 , Amir Mistric wrote:
I must admit - not the most elegant approach...
I have to issue 5 different mvn installs to get the desired result..
Yes and no ... see below.
What is the point of -Pwith-optional-modules then?
It's existence need to be revised. See below, too.
Not trying to be difficult here Philip, but we are saying workflow
and samples are optional modules but they, unlike dms, do not have
a separate lifecycle...Right?
... not yet. They will, eventually.
If I am using reactor mode (with mvn -Dall=true -Pwith-optional-
modules clean install)
I should be getting a WEB-INF/lib artifacts that are representative
of the current build not some incompatible version downloaded from
maven repo...
Right now if you do mvn -Dall=true -Pwith-optional-modules clean
install and try to deploy the webapp that is built it will fail to
deploy not because of Maven dependency but because of Magnolia
enforced dependency on a module that Maven was "told" to package...
Again, my argument is not to change DMS lifecycle but to devise an
easy way where I can build (from latest source) Magnolia webapp
that has workflow, samples, and DMS...
This would speed up the testing, in my opinion....
Points taken, but :
1. We wanted to focus on getting 3.5 out the door.
2. We realize the intentions are currently unclear for most people.
3. We're planning on (finally) starting to document Magnolia
properly. The build mechanism is one of the hot topics.
4. Once 3.5 is out the door, we'll be able to look at it again, and
while documenting, we might realize things need to either be
documented, dropped or changed.
5. The main point which is probably unclear at the moment, is that
your own webapp, if any, should depend on magnolia-empty-webapp, and
add the dependencies to the modules you need. (i.e you should clone
the magnolia-bundled-webapp and tailor it to your needs rather than
extend/depend on it) Building all at once ("with-optional-modules")
is merely a commodity for Magnolia developers .. and might be
dropped. It made sense during development of 3.5 because the whole
effort was spread between magnolia itself and other modules. Now
we're reaching a more stable state, dms will depend on the latest
stable release of Magnolia (3.5), and not a potential future next
snapshot, at least until it *actually* needs changes in said
potential future next version, and vice-versa. Examples: (a) we might
release a minor version of dms before any other next version of
magnolia itself, which means a potential dms 1.2.1 *has to* depend on
magnolia 3.5 (b) conversely, we might release a bugfix of magnolia
and release a complete bundle, which would still be bundled dms 1.2.
Another point to keep in mind (same idea) is that the "new" magnolia-
bundle project and subprojects are not meant to be used as is by
projects extending magnolia, but only as packaging projects for
actual Magnolia releases as a product.
For the same reasons, I understand it made sense for your project to
depend on snapshots until the release, but now that stable versions
are out, we'd really advise you to depend on these. And hopefully,
the separate lifecycle of modules should help releasing more often ;)
(and, hot news, for bleeding edge addicts, we might actually have
real nightly builds available "soonish")
Hope this clarifies a few things and helps, too. We've looked at the
issue from a bunch of different angles (admittedly under pressure of
releasing, which I hope explains why it hasn't been clearly
communicated yet, and why some inconsistencies (profiles) might still
be leftover), and until now this seemed like the best solution for us
(or the less bad, depending on how you look at it)
Let us know what you think !
cheers
greg
-----Original Message-----
From: [email protected] [mailto:[EMAIL PROTECTED]
Sent: Wednesday, December 12, 2007 6:02 AM
To: [email protected]
Subject: Re: [magnolia-dev] latest deploy error - DMS version
The dms has its own lifecycle which means that we don't
update its pom on every release of the main project. In the
moment where you build all together (main project, dms, ...)
maven is smart enough to take only the latest version of
core. Check the webapp after the build and WEB-INF/lib should be
fine.
After releasing the webapp pom will not update to the latest
dms snapshot immediately as it depends upon the latest stable
release of dms.
As we have more and more modules (workflow, dms, data,
scheduler, forum, poll) you might see why this things are
that much independent.
To be on the save side you do:
- mvn install main project
- mvn install of the modules
- mvn install of the webapp
In case you have to build all in one reactor you must update
the poms yourself.
Philipp Bracher
On 11.12.2007, at 17:17, Amir Mistric wrote:
Well
I just tried again and this time I deleted all magnolia
artifacts from
local repo (except parent pom and build tools) and used:
mvn -o -Dall=true -Pwith-optional-modules clean install
The DMS fails to build because it "wants" specifically:
1) info.magnolia:magnolia-core:jar:3.5-rc2
2) info.magnolia:magnolia-gui:jar:3.5-rc2
3) info.magnolia:magnolia-module-admininterface:jar:3.5-rc2
4) info.magnolia:magnolia-taglib-cms:jar:3.5-rc2
I did "offline" on purpose to see if the DMS would use
artifacts from
the current build (RC4) that are bing installed as I build them...
But then I checked the DMS POM and sure enough, it is not
depending on
rc4 artifacts...
Regards
Amir
-----Original Message-----
From: [email protected] [mailto:[EMAIL PROTECTED]
Sent: Monday, December 10, 2007 3:38 PM
To: [email protected]
Subject: Re: [magnolia-dev] latest deploy error - DMS version
Am 10.12.2007 um 14:49 schrieb Amir Mistric:
Just did a SVN update and tried to deploy the WAR with workflow,
samples and DMS....
ERROR org.apache.catalina.core.ContainerBase.[jboss.web].
[localhost].[/magnoliaAuthor] StandardContext.java(listenerStart:
3767) 10.12.2007 08:44:34 Exception sending context
initialized event
t o listener instance of class
info.magnolia.cms.servlets.MgnlServletContextListener
java.lang.RuntimeException:
info.magnolia.module.model.reader.ModuleDependencyException: Module
dms (version 1.2.0-SNAPSHOT) is dependent on
adminInterface version
3.1, but Magnolia Admin Interfa ce Module (version
3.5.0-rc4-SNAPSHOT)
is currently installed.
at
info.magnolia.cms.servlets.MgnlServletContextListener.contextInitiali
z
ed(MgnlServletContextListener.java:200)
are you sure that the latest DMS is also build in your
maven reactor
and not picked up from you local or Magnolia's snapshot mvn
repository? It seems that the dms.xml module descriptor file still
has the dependency to admin interface
3.1 which is not the case since
r12536 (November, 14th) anymore. Maybe dms 1.2 snapshot was not
deployed since, thus Magnolia's snapshot repo is not up-to-date.
HTH.
Cheers,
- vivian
I know that DMS is on a "separate" development cycle, but
it would be
nice to be able to test with these 3 modules :)
Regards
Amir
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/docs/en/editor/stayupdated.html
----------------------------------------------------------------
