Hi Rayn,
Many thanks for your nice work! I applied the patches. 3.5.3 will be
released on Monday
Have a nice day!
Philipp Bracher
On 10.01.2008, at 18:39, Ryan Gardner wrote:
I know everyone has different priorities for things... but a few
weeks ago I submitted a patch to fix a bug in the cms:out... To
help move things along in the tag library area, I wrote a tag
library unit test helper class and wrote a simple unit test for the
cms:out that tests the uuidLink behavior. I think that if you
inspect / apply 1986 first, and run the tests - you should see the
bug that I identified in 1978, and then when you apply the patch
for 1978, you will see the unit test properly executes.
I know that you are busy, but I tried my hardest to make it
extremely easy to just take these patches and run with them. If you
have any feedback for me on what you would prefer for me to do in
the future - or anything I can do to these patches to get them to
the point they can be accepted - I'm all ears.
Here are the jira links to the things I'm talking about:
http://jira.magnolia.info/browse/MAGNOLIA-1986
[ A unit-test helper for the tag library, with a series of unit
tests to illustrate the bug in the uuidLink in cms:out ]
http://jira.magnolia.info/browse/MAGNOLIA-1978
[ Patch to fix the bug in the cms:Out related to the uuidLink output ]
And for good measure, there is this other patch - that I really
don't care if it gets applied or not... I just did it to be
helpful, but since it doesn't impact any functionality, I don't care.
http://jira.magnolia.info/browse/MAGNOLIA-1979
[ adds some more documentation to the tld... ]
Again - any feedback would be appreciated.
Ryan
