[
http://jira.magnolia.info/browse/MAGNOLIA-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913#action_16913
]
gjoseph edited comment on MAGNOLIA-1986 at 7/8/08 3:14 AM:
------------------------------------------------------------------
funnily enough, I only just noticed the assertJspContent() methods were never
doing any actual assertions. Luckily, the tests still pass once adding it ;)
Thanks though, very useful - i was able to add a couple of tests for
MAGNOLIA-2012 in just a minute :)
Fixed on 3.5 branch (3.5.9 being the next possible release) and trunk (3.6)
was (Author: gjoseph):
funnily enough, I only just noticed the assertJspContent() methods were
never doing any actual assertions. Luckily, the tests still pass once adding it
;)
Applied to 3.5 branch (3.5.9 being the next possible release) and trunk (3.6)
> Magnolia tag libraries lack unit tests
> --------------------------------------
>
> Key: MAGNOLIA-1986
> URL: http://jira.magnolia.info/browse/MAGNOLIA-1986
> Project: Magnolia
> Issue Type: Improvement
> Components: taglibs
> Reporter: Ryan Gardner
> Assignee: Vivian Steller
> Fix For: 3.5.3, 3.5.x, 3.6
>
> Attachments: AddingTaglibTest-revised.patch, AddUnitTestForOut.patch
>
>
> I've found a handful of bugs in the tag libraries that have been a real
> nuisance to isolate. I wrote a MgnlTagTestCase to help create the necessary
> mock objects to test the existing tags unchanged (i.e. test them as they spit
> out content to the JspWriter - and verify that the output is what is expected)
> In the attached patch, I also have a test started for the cms:out tag - this
> test case only covers the UUID link output that I logged in another issue (
> http://jira.magnolia.info/browse/MAGNOLIA-1978 )
> This change should not interfere with anything else - it just adds the
> ability to more easily generate tests for the tag library functions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------
