[ 
http://jira.magnolia.info/browse/MAGNOLIA-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Joseph updated MAGNOLIA-2240:
-------------------------------------

    Description: 
This issue was discovered because the CacheFilter class should have had a 
"cacheConfigurationName" instead of "cacheConfiguration". The actual variable 
had the correct name and so did the bootstrap file, but the getter/setter pair 
was wrong; as a result, the default cache config was always used.

* If the {{cacheConfigurationName}} isn't set, we will output a warning log 
statement and fallback to the default (instead of assigning the default value 
to the variable on initialization)
* If the module can't return a Cache or CacheConfiguration from 
{{cacheConfigurationName}}, we will output an error log statement and disable 
the filter. (once the configuration is fixed the filter gets reloaded through 
the magic of {{CacheModuleLifecycleListener}})

  was:
This issue was discovered because the CacheFilter class should have had a 
"cacheConfigurationName" instead of "cacheConfiguration". The actual variable 
add the correct name and so did the bootstrap file, but the getter/setter pair 
was wrong; as a result, the default cache config was always used.

* If the {{cacheConfigurationName}} isn't set, we will output a warning log 
statement and fallback to the default (instead of assigning the default value 
to the variable on initialization)
* If the module can't return a Cache or CacheConfiguration from 
{{cacheConfigurationName}}, we will output an error log statement and disable 
the filter. (once the configuration is fixed the filter gets reloaded through 
the magic of {{CacheModuleLifecycleListener}})


> CacheFilter should check its configuration and disable itself if it's invalid
> -----------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2240
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2240
>             Project: Magnolia
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 3.6-m3
>            Reporter: Gregory Joseph
>            Assignee: Gregory Joseph
>             Fix For: 3.6
>
>
> This issue was discovered because the CacheFilter class should have had a 
> "cacheConfigurationName" instead of "cacheConfiguration". The actual variable 
> had the correct name and so did the bootstrap file, but the getter/setter 
> pair was wrong; as a result, the default cache config was always used.
> * If the {{cacheConfigurationName}} isn't set, we will output a warning log 
> statement and fallback to the default (instead of assigning the default value 
> to the variable on initialization)
> * If the module can't return a Cache or CacheConfiguration from 
> {{cacheConfigurationName}}, we will output an error log statement and disable 
> the filter. (once the configuration is fixed the filter gets reloaded through 
> the magic of {{CacheModuleLifecycleListener}})

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------

Reply via email to