[ 
http://jira.magnolia.info/browse/MGNLPUR-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208#action_17208
 ] 

gjoseph edited comment on MGNLPUR-17 at 7/22/08 11:28 AM:
-----------------------------------------------------------------

You don't always have a request when generating an email, which is the point of 
the {{defaultBaseUrl}} setting (think about sending an email from a workflow). 
If you need a different behaviour than a single possible baseurl, you can 
always swap the behaviour that sends an email with a custom one, which is the 
whole point of these "behaviours", too.

Also, deriving the baseurl from the request does not always work either - think 
reverse proxies.  {{defaultBaseUrl}} actually give you the benefit of choosing 
how links for external systems (emails, ...) look like.

      was (Author: gjoseph):
    You don't always have a request when generating an email, which is the 
point of the {{defaultBaseUrl}} setting (think about sending an email from a 
workflow). If you need a different behaviour than a single possible baseurl, 
you can always swap the behaviour that sends an email with a custom one, which 
is the whole point of these "behaviours", too.
  
> defaultBaseUrl used in the email.html template should get it's value from the 
> request URI
> -----------------------------------------------------------------------------------------
>
>                 Key: MGNLPUR-17
>                 URL: http://jira.magnolia.info/browse/MGNLPUR-17
>             Project: Magnolia Public User Registration
>          Issue Type: Improvement
>            Reporter: Will Scheidegger
>            Assignee: Gregory Joseph
>            Priority: Minor
>
> The registration confirmation mails sent out use "defaultBaseUrl" to setup 
> the link which lets the user confirm his/her registration. This value is 
> taken form config:/server/defaultBaseUrl which makes it impossible to use PUR 
> on more than one domain in an instance. It would be preferable if the base 
> url + context path would be derived from the request URI.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------

Reply via email to