[
http://jira.magnolia.info/browse/MAGNOLIA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregory Joseph resolved MAGNOLIA-2310.
--------------------------------------
Fix Version/s: 3.6.2
Resolution: Fixed
Haaa, awesome, thanks ! Somebody reported this on the users list but had no
time to investigate yet. Patch applied, thanks !
> GZipFilterTest test incorrectly uses int literal for a newline length count
> ---------------------------------------------------------------------------
>
> Key: MAGNOLIA-2310
> URL: http://jira.magnolia.info/browse/MAGNOLIA-2310
> Project: Magnolia
> Issue Type: Bug
> Components: cache
> Affects Versions: 3.6.1
> Environment: windows
> Reporter: Joshua Frankamp
> Assignee: Gregory Joseph
> Priority: Minor
> Fix For: 3.6.2
>
> Attachments: GZipFilterTest.diff
>
>
> Newline should be derived, not hard coded. It isn't 1 on windows.
> I included the diff here, and attached it.
> Index: GZipFilterTest.java
> ===================================================================
> --- GZipFilterTest.java (revision 17249)
> +++ GZipFilterTest.java (working copy)
> @@ -107,7 +107,7 @@
> final byte[] compressedBytes = finalOutput.toByteArray();
> assertTrue("output should be gzipped",
> GZipUtil.isGZipped(compressedBytes));
> final byte[] uncompressed = GZipUtil.ungzip(compressedBytes);
> - final int expectedLength = iterations *
> (SOME_10CHARSLONG_CHAIN.length() + 1); // n chars + newline
> + final int expectedLength = iterations *
> (SOME_10CHARSLONG_CHAIN.length() +
> System.getProperty("line.separator").length()); // n chars + newline
> assertEquals(expectedLength, uncompressed.length);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------
