Hi Gregory, Great - I've created a user with the login 'sniffy', which I'll use in the future to submit patches.
/Ian -----Original Message----- From: [email protected] [mailto:[EMAIL PROTECTED] Sent: Tuesday, August 12, 2008 12:30 PM To: [email protected] Subject: Re: [magnolia-dev] magnolia-module-cache diff Hi Ian, Thanks for this ! Yes, ideally, bug reports and patches go to Jira, so we can at least keep track of what was fixed and when. I'll do it this time around ;) Thanks for the great reports and patches - if you have a user id on Jira let me know, I'll fix the "reporter" field. -g On Aug 12, 2008, at 10:53 AM, Ian Johannesen wrote: > Hi, > > First of all I'm quite new to this list - so whether or not you want > diffs on this list or only in JIRA I'm blissfully unaware of. So here > goes anyway. > > I've discovered what seems to be two bugs in the cache module (I'm > building the trunk, which currently is 3.6.2-SNAPSHOT) > 1) When not using a locale on the locale machine, which would make > Locale.ENGLISH the default locale. The parsing of the Last-Modified > header makes it throw tons of exceptions (ParseException in > info.magnolia.module.cache.filter.CacheResponseWrapper:145) > 2) The expiration is set to +400 months from now even though the > requested amount in minutes is 30. This seems to be because > System.currentTimeMillis() isn't subtracted - or not factored into the > calculations in > info.magnolia.module.cache.executor.SetExpirationHeaders:76. > > I've attached a diff against the current trunk (svn diff), which can > be > applied to clean up the two above mentioned bugs. > > Thanks for a great content management system! > > BR, > > Ian Johannesen > <magnolia-module-cache-3.6.2- > SNAPSHOT > .diff>---------------------------------------------------------------- > for list details see > http://documentation.magnolia.info/ > ---------------------------------------------------------------- ---------------------------------------------------------------- for list details see http://documentation.magnolia.info/ ---------------------------------------------------------------- ---------------------------------------------------------------- for list details see http://documentation.magnolia.info/ ----------------------------------------------------------------
