[ 
http://jira.magnolia.info/browse/MAGNOLIA-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dallas Vaughan updated MAGNOLIA-2319:
-------------------------------------

    Description: 
This method is called within the 
info.magnolia.module.delta.WebXmlConditionsUtil.filterMustBeRegisteredWithCorrectDispatchers
 method, to test that there are REQUEST and FORWARD dispatchers configured in 
the web.xml file before starting/installing the core module.

However, in our case we have added the INCLUDE dispatcher in order to enable 
inclusion of magnolia content into other web apps.  Since this test only passes 
if there are *only* these two dispatchers configured (with optional "ERROR"), 
it fails even if these 2 dispatchers are present along with the INCLUDE.  This 
prevents the core module from installing on bootstrapped startup.

I think it should only test the mandatory presence of REQUEST and FORWARD, and 
not validate additional dispatchers.



  was:
This method is called within the 
info.magnolia.module.delta.WebXmlConditionsUtil.filterMustBeRegisteredWithCorrectDispatchers
 method, to test that there are REQUEST and FORWARD dispatchers configured in 
the web.xml file before starting/installing the core module.

However, in our case we have added the INCLUDE dispatcher in order to enable 
inclusion of magnolia content into other web apps.  Since this test only passes 
if there are <b>only</b> these two dispatchers configured (with optional 
"ERROR"), it fails even if these 2 dispatchers are present along with the 
INCLUDE.  This prevents the core module from installing on bootstrapped startup.

I think it should only test the mandatory presence of REQUEST and FORWARD, and 
not validate additional dispatchers.




> info.magnolia.cms.util.WebXmlUtil.areFilterDispatchersConfiguredProperly 
> method is overly strict
> ------------------------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2319
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2319
>             Project: Magnolia
>          Issue Type: Bug
>          Components: core
>            Reporter: Dallas Vaughan
>            Assignee: Philipp Bracher
>
> This method is called within the 
> info.magnolia.module.delta.WebXmlConditionsUtil.filterMustBeRegisteredWithCorrectDispatchers
>  method, to test that there are REQUEST and FORWARD dispatchers configured in 
> the web.xml file before starting/installing the core module.
> However, in our case we have added the INCLUDE dispatcher in order to enable 
> inclusion of magnolia content into other web apps.  Since this test only 
> passes if there are *only* these two dispatchers configured (with optional 
> "ERROR"), it fails even if these 2 dispatchers are present along with the 
> INCLUDE.  This prevents the core module from installing on bootstrapped 
> startup.
> I think it should only test the mandatory presence of REQUEST and FORWARD, 
> and not validate additional dispatchers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------

Reply via email to