[ 
http://jira.magnolia.info/browse/MAGNOLIA-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923#action_17923
 ] 

gjoseph edited comment on MAGNOLIA-2361 at 9/12/08 4:48 PM:
-------------------------------------------------------------------

My main concern was actually for when the class property exists but does not 
have any value; I just realized that in fact the error log was still pretty 
clear in this case:
{noformat}
WARN  info.magnolia.content2bean[...] can't resolve class for node 
/modules/adminInterface/virtualURIMapping/default
java.lang.ClassNotFoundException:
at java.lang.Class.forName0(Native Method)
[...]
{noformat}
However I've just added a little check that will behave exactly the same way if 
the class property is empty, but with a more explicit message in the 
ClassNotFoundException than an empty string.

      was (Author: gjoseph):
    My main concern was actually for when the class property exists but does 
not have any value; I just realized that in fact the error log was still pretty 
clear in this case:
{noformat}
WARN  info.magnolia.content2bean.impl.Content2BeanProcessorImpl 
Content2BeanProcessorImpl.java(toBean:88) 12.09.2008 14:20:27  can't resolve 
class for node /modules/adminInterface/virtualURIMapping/default
java.lang.ClassNotFoundException:
at java.lang.Class.forName0(Native Method)
[...]
{noformat}
However I've just added a little check that will behave exactly the same way if 
the class property is empty, but with a more explicit message in the 
ClassNotFoundException than an empty string.
  
> Content2bean: get a more explicit message when class property exists but is 
> empty
> ---------------------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2361
>                 URL: http://jira.magnolia.info/browse/MAGNOLIA-2361
>             Project: Magnolia
>          Issue Type: Bug
>          Components: core
>            Reporter: Gregory Joseph
>            Assignee: Gregory Joseph
>             Fix For: 3.6.2
>
>
> original title: fallback to default implementation when class property is 
> empty or wrongly set ?
> To be discussed: as per MAGNOLIA-1688, it might be useful to fallback to the 
> default implementation class when a {{class}} property is set to an 
> unexisting class or is empty. I am not entirely convinced, because this is 
> typically a configuration mistake and it should not be ignored. Maybe a 
> precise warning/error log before falling back would be good. (depending on 
> what component is being configured, this could otherwise block the system - 
> i.e for filters for instance)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------

Reply via email to