[
http://jira.magnolia.info/browse/MAGNOLIA-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18087#action_18087
]
Jan Haderka commented on MAGNOLIA-285:
--------------------------------------
The source of the issue is the fact that multipart filter (or the underlying
code to deal with multipart request data) saves temp files with the exactly
same names as they come in multipart form which (if the timing is right)
results in file being either overridden, corrupted or deleted. This could be
potentially more disastrous when two users tried to upload file with same name
but different content at a same time.
> Uploading multiple files with the same filename causes exception
> ----------------------------------------------------------------
>
> Key: MAGNOLIA-285
> URL: http://jira.magnolia.info/browse/MAGNOLIA-285
> Project: Magnolia
> Issue Type: Bug
> Components: core
> Affects Versions: 2.01, 3.0 RC4
> Environment: Tested on Mac OS X, Linux and Windows and with multiple
> browsers.
> Reporter: Andreas Weder
> Assignee: Philipp Bracher
> Priority: Minor
>
> I have a paragraph, which allows me to upload multiple images, and another
> one for multiple files.
> If at least two files have the same file name, I get the following exception:
> org.apache.jasper.JasperException
>
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:372)
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
> org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
>
> info.magnolia.cms.Filter.MultipartRequestFilter.doFilter(MultipartRequestFilter.java:76)
>
> info.magnolia.cms.Filter.ContentTypeFilter.doFilter(ContentTypeFilter.java:52)
> root cause
> java.lang.NullPointerException
> info.magnolia.cms.beans.runtime.Document.delete(Document.java:153)
> info.magnolia.cms.gui.control.Save.save(Save.java:242)
>
> org.apache.jsp.admintemplates.dialogs.standard_jsp._jspService(standard_jsp.java:103)
> org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
>
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324)
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
> org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
>
> info.magnolia.cms.Filter.MultipartRequestFilter.doFilter(MultipartRequestFilter.java:76)
>
> info.magnolia.cms.Filter.ContentTypeFilter.doFilter(ContentTypeFilter.java:52)
> Workaround:
> Upload the files with the same file name sequentally.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------
