In upgrading to version 2.3.3, I found a number of bugs and have included
patches below which fix all of the problems listed. Some of these bugs are
new to 2.3.3, some have existed in previous versions.
cgi-bin/manage.cgi
------------------
1. $reg_encoding_type not needed anymore.
2. view_waiting_history included twice in action list.
3. The message for $CANT_SUPPORT{$tld} hard codes ".ca" even though the
test is against $tld, not .ca. Fix the message to use $tld. This
happens in three places.
4. When showing $path_templates/expire_domains_result.html, be sure to set
the {{CGI}} template variable.
cgi-bin/reg_system.cgi
----------------------
1. $reg_encoding_type not needed anymore.
2. $HTML{auto_renew_section} in do_setup_profile() isn't used by any
templates. Also, $HTML{AUTO_RENEW} (which is used in the templates) is
set to the same thing just above.
templates/manage/base2.html
---------------------------
1. Remove link to nowhere for "Warning! Names expiring!"
2. Add link to view_waiting_history for "Waiting Request" banner.
templates/reg_system/ca_main_menu.html
templates/reg_system/main_menu.html
templates/reg_system/order.html
templates/reg_system/taken.html
templates/reg_system/verify.html
templates/renew/renew_domain_menu.html
--------------------------------------
1. Remove <input type=hidden name=encoding_type value="{{encoding_type}}">
from all of the templates as it is no longer used.
Here is the patch that includes all of the above changes:
--- cgi-bin/manage.cgi 2001/05/05 07:15:57 1.1.1.4
+++ cgi-bin/manage.cgi 2001/05/05 07:47:30 1.12
@@ -31,7 +31,7 @@
$authentication $cgi $path_templates $flag_header_sent
$reg_username $reg_password $reg_domain $cookie $domain_count
$reg_permission $reg_f_owner $expiredate $last_access_time
- $last_ip %contact_keys $waiting_request $reg_encoding_type
+ $last_ip %contact_keys $waiting_request
$COOKIE_KEY $reg_domain_race_obj %enctypes $T_EXPIRED $T_EXPIRING $t_mode
$notice_days
$UNIVERSAL_ENCODING_TYPE
);
@@ -137,7 +137,6 @@
do_change_password => undef,
change_ownership => undef,
do_change_ownership => undef,
- view_waiting_history => undef,
view_waiting_history => undef,
get_expire_domains => undef,
@@ -795,8 +795,8 @@
if ( exists $CANT_SUPPORT{$tld} )
{
my $message = <<EOF;
-You cannot currently make changes to .ca domains through this<BR>
-interface. We will have a .ca enabled Manage Domain interface in place as<BR>
+You cannot currently make changes to $tld domains through this<BR>
+interface. We will have a $tld enabled Manage Domain interface in place as<BR>
soon as possible.</P>
If need to make emergency nameserver changes to your domain, please contact
<a href="mailto:support\@opensrs.org";>support\@opensrs.org</a>.
@@ -1879,8 +1879,8 @@
if ( exists $CANT_SUPPORT{$tld} )
{
my $message = <<EOF;
-You cannot currently make changes to .ca domains through this<BR>
-interface. We will have a .ca enabled Manage Domain interface in place as<BR>
+You cannot currently make changes to $tld domains through this<BR>
+interface. We will have a $tld enabled Manage Domain interface in place as<BR>
soon as possible.</P>
If need to make emergency nameserver changes to your domain, please contact
<a href="mailto:support\@opensrs.org";>support\@opensrs.org</a>.
@@ -2278,6 +2278,7 @@
if ($updated_domain_html) {
$HTML{DOMAINS} = $updated_domain_html;
$HTML{TITLE} = "Update Status";
+ $HTML{CGI} = $cgi;
print_form("$path_templates/expire_domains_result.html",\%HTML);
exit;
}
@@ -2579,8 +2580,8 @@
if ( exists $CANT_SUPPORT{$tld} ) {
my $message = <<EOF;
-You cannot currently make changes to .ca domains through this<BR>
-interface. We will have a .ca enabled Manage Domain interface in place as<BR>
+You cannot currently make changes to $tld domains through this<BR>
+interface. We will have a $tld enabled Manage Domain interface in place as<BR>
soon as possible.</P>
If need to make emergency nameserver changes to your domain, please contact
<a href="mailto:support\@opensrs.org";>support\@opensrs.org</a>.
--- cgi-bin/reg_system.cgi 2001/05/05 07:15:57 1.1.1.4
+++ cgi-bin/reg_system.cgi 2001/05/05 17:13:53 1.10
@@ -29,7 +29,7 @@
$reg_username $reg_password $reg_domain $cookie $domain_count
$reg_permission $reg_f_owner $expiredate $last_access_time
$last_ip %contact_keys $waiting_request $domain_info
- $reg_domain_race_obj $reg_encoding_type
+ $reg_domain_race_obj
$COOKIE_KEY
);
( %in, %contact_types, %actions, $XML_Client, %cookies, $action,
@@ -37,7 +37,7 @@
$reg_username, $reg_password, $reg_domain, $cookie, $domain_count,
$reg_permission, $reg_f_owner, $expiredate, $last_access_time,
$last_ip, %contact_keys, $waiting_request, $reg_domain_race_obj,
- $reg_encoding_type, $domain_info
+ $domain_info
) = ();
@@ -1589,16 +1588,6 @@
$HTML{domains} = join "<br>\n", @domains;
$htmlForm = "$path_templates/order$domainCountry.html";
- }
-
- if ($REG_SYSTEM{AUTO_RENEW_ENABLED}) {
- $HTML{auto_renew_section} = <<EOF;
-<TR>
- <TD ALIGN=right bgcolor="#e0e0e0"><B>Auto renew:</B></TD>
- <TD><INPUT NAME="auto_renew" TYPE="radio" value="1"> Yes
- <INPUT NAME="auto_renew" TYPE="radio" value="0" CHECKED> No </TD>
-</TR>
-EOF
}
print_form($htmlForm,\%HTML);
--- templates/manage/base2.html 2001/05/05 07:15:58 1.1.1.2
+++ templates/manage/base2.html 2001/05/05 07:47:30 1.4
@@ -8,8 +8,7 @@
<center><table BORDER CELLSPACING=0 CELLPADDING=2 WIDTH="550" >
<tr>
-<td ALIGN=CENTER BGCOLOR="#000080"><b><font face="verdana, arial"><font
color="#FFFFFF"><font size=-1><a href="{{CGI}}"
STYLE="color:#FFFFFF;text-decoration:none;">Warning!
-Names expiring!</a></font></font></font></b></td>
+<td ALIGN=CENTER BGCOLOR="#000080"><b><font face="verdana, arial"><font
+color="#FFFFFF"><font size=-1>Warning! Names expiring!</font></font></font></b></td>
</tr>
<tr>
@@ -43,8 +42,8 @@
<tr>
<td ALIGN=CENTER><b><font face="verdana, arial"><font size=-1>Expires:
-{{EXPIREDATE}} </font></font></b> <b><font face="verdana,
arial"><font size=-1>Waiting
-Request: {{WAITING_REQUEST}} </font></font></b></td>
+{{EXPIREDATE}} </font></font></b> <b><font face="verdana,
+arial"><font size=-1><a href="{{CGI}}?action=view_waiting_history">Waiting
+Request</a>: {{WAITING_REQUEST}} </font></font></b></td>
</tr>
</table>
</td>
--- templates/reg_system/ca_main_menu.html 2001/05/05 07:15:58 1.1.1.3
+++ templates/reg_system/ca_main_menu.html 2001/05/05 17:15:43 1.2
@@ -6,7 +6,6 @@
<FORM ACTION="{{CGI}}" METHOD="post">
<input type=hidden name=affiliate_id value="{{affiliate_id}}">
<input type=hidden name=action value="lookup">
- <input type=hidden name=encoding_type value="{{encoding_type}}">
<TD>
<TABLE BORDER="1" CELLSPACING="1" CELLPADDING="1">
--- templates/reg_system/main_menu.html 2001/05/05 07:15:58 1.1.1.3
+++ templates/reg_system/main_menu.html 2001/05/05 17:15:43 1.5
@@ -6,7 +6,6 @@
<FORM ACTION="{{CGI}}" METHOD="post">
<input type=hidden name=affiliate_id value="{{affiliate_id}}">
<input type=hidden name=action value="lookup">
- <input type=hidden name=encoding_type value="{{encoding_type}}">
<TD>
<TABLE BORDER="1" CELLSPACING="1" CELLPADDING="1">
<TR>
--- templates/reg_system/order.html 2001/05/05 07:15:58 1.1.1.3
+++ templates/reg_system/order.html 2001/05/05 17:15:43 1.7
@@ -281,6 +281,5 @@
<input type=hidden name=reg_domain value="{{reg_domain}}">
<input type=hidden name=reg_type value="{{reg_type}}">
<input type=hidden name=bulk_order value="{{bulk_order}}">
-<input type=hidden name=encoding_type value="{{encoding_type}}">
</form>
<BR>
--- templates/reg_system/taken.html 2001/05/05 07:15:58 1.1.1.2
+++ templates/reg_system/taken.html 2001/05/05 17:15:43 1.4
@@ -11,7 +11,6 @@
<FORM method="post" ACTION="{{CGI}}">
<input type=hidden name=affiliate_id value="{{affiliate_id}}">
<input type=hidden name=action value=lookup>
- <input type=hidden name=encoding_type value="{{encoding_type}}">
<TD>
<TABLE BORDER="1" CELLSPACING="1" CELLPADDING="1">
--- templates/reg_system/verify.html 2001/05/05 07:15:58 1.1.1.2
+++ templates/reg_system/verify.html 2001/05/05 17:15:43 1.4
@@ -70,7 +70,6 @@
<BR>
<input type=hidden name=affiliate_id value="{{affiliate_id}}">
-<input type=hidden name=encoding_type value="{{encoding_type}}">
<input type=hidden name=reg_username value="{{reg_username}}">
<input type=hidden name=reg_password value="{{reg_password}}">
<input type=hidden name=reg_domain value="{{reg_domain}}">
--- templates/renew/renew_domain_menu.html 2001/05/05 07:15:58 1.1.1.3
+++ templates/renew/renew_domain_menu.html 2001/05/05 17:15:43 1.4
@@ -51,7 +51,6 @@
<tr>
<td colspan="5" align="center">
<input type=hidden name="reg_domain" value="{{reg_domain}}">
- <input type=hidden name="reg_encoding_type"
value="{{reg_encoding_type}}">
<input type="submit" name="submit" value=" Renew Domain Now ">
</td>
</tr>
</HTML>
