Charles,

Did OpenSRS release any patch code to validate
that the customer put in an email address into the new
2.53 code?

Some orders were coming in without an email or sometimes
without an organization name.

I wrote a quick fix. It doesn't check email format, but
it looks to see whether you put in an org_name and
email address, and stops transactions from failing
because of those 2 reasons.

I inserted this into verify_order and it does a temporary fix.

Its very simple code but hope this helps.

#### mod check org name and email address ###

        unless($in{owner_org_name}){
                print "<br><br><br><u><b>Error:</b></u> <b>You forgot to supply a
Registrant \"<u>Organization name</u>\". Hit the back button and look for a
yellow areas to fill in<br>Hit the back button to correct the organization
name</b><br>";
            exit;
        }

        unless( ($in{billing_org_name})&&($in{admin_org_name}) ){
                $in{billing_org_name} = $in{owner_org_name};
                $in{admin_org_name}   = $in{owner_org_name};
        }

        unless($in{owner_email}){
                print "You forgot to supply an Email Address. Hit the back button to 
fill
in an email address.<br>";
            exit;
        }

        unless( ($in{billing_email})&&($in{admin_email}) ){
                $in{billing_email} = $in{owner_email};
                $in{admin_email}   = $in{owner_email};
        }

    ##################################################################

 Jonathan Lee
 Tech Manager
 415-682-3859
 http://123cheapdomains.com

-----Original Message-----
From: Charles Daminato [mailto:[EMAIL PROTECTED]]
Sent: Monday, April 29, 2002 10:46 AM
To: [EMAIL PROTECTED]
Subject: RE: verify_order


Jon...

Read through for my comments.

Charles Daminato
OpenSRS Product Manager
Tucows Inc. - [EMAIL PROTECTED]

> -----Original Message-----
> From: Jonathan [mailto:[EMAIL PROTECTED]]
> Sent: April 27, 2002 7:59 PM
> To: Charles Daminato
> Subject: RE: verify_order
>
>
>
>
> Charles,
>
> I thought people were going to miss and forget to put
> in their nexus and Application purpose data,
> and so I had the form data defaulted aa:
>
> business use
> and Category 1
>
> to avoid any errors.

Make sure you note that you're defaulting to a value if they don't select
anything and it must be accurate or they could get disputed.

>
> I'm relying on them to change it if that isn't
> the correct default.
>
> The .US also doesn't check to see if they entered
> in an Organization name, and quite a few people don't
> put anything in that box because in their mind, they
> don't belong to any organization or its for personal use.
> This causes an error at the end.
>
> So I included in a bold red statements:
>
>   "If there is no organization company name, then just put your first and
> last name.
>    You must at least put something into this organization text box."

We're releasing (shortly) an updated client code that does syntax checking.

>
> Quite a few of the lookups and submits fail
> when submitted into my reseller interface from my API.
>
> Do you know what is the problem or why that happens?

.us registry is having some *growing* pains and problems.  We're working
with the registry to sort this out and find a resolution, in the interim all
we can ask for is patience :)

>
> I eliminated a few problems by not allowing anyone to
> use "custom nameservers," and so my nameservers are always correct.
>
> I noticed people tend to put very strange things inside those name server
> boxes:
> like:
>
> http://www.geocities.com/username
> or an IP address
> instead of a nameserver.
>
> Is there anything I should be look out for
> to elimate as many possible errors while
> submitting into my Reseller interface?

Try to explain to the user on the form what each field is actually for, you
can't really catch all the errors (someone will always surprise you)

>
> What all all possible sources of error?
>
> I located a few common:
>
> 1. wrong nameserver entered.
> 2. SRS failed to lookup name
> 3. missing org name.
> 4. missing email. (duh, i forgot to write a check for this)
>    I noticed this one when I got an email of "nobody"
>
> Any others?

That I can think of (we've got syntax checking in, just have to release it):

a) phone number format (the +XXX.XXXX... thingy)
b) length of fields (try to keep them under 30 characters where possible)

>
>  Jonathan Lee
>  Tech Manager
>  415-682-3859
>  http://123cheapdomains.com
>
> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On
> Behalf Of Charles Daminato
> Sent: Friday, April 26, 2002 11:00 AM
> To: [EMAIL PROTECTED]
> Subject: RE: verify_order
>
>
> AHA!  This is from our dev group, updates will come (and announcements,
> released, and re-versioned client codes I imagine)
>
> It is the custom_verify = "us" that's causing the problem.
> Looks like a legacy of my development in not using XML_Client's
> validate_contacts().  Until a new client is released, you just has to
> comment out the line where custom_verify is set to "us".  But we
> also found
> that local validation of the .us nexus data is missing (OOPS!  Sorry
> *pout*).  We're working on that now, so we will release a new
> client sooner
> than later.
>
> Charles Daminato
> OpenSRS Product Manager
> Tucows Inc. - [EMAIL PROTECTED]
>
> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On
> Behalf Of Dev-List
> Sent: April 26, 2002 11:03 AM
> To: ST; Tech; [EMAIL PROTECTED]
> Subject: Re: verify_order
>
>
> Honestly, I have not had time to look into the error further. If I get a
> chance today (I hope) I will and let you both know when/if I find out ;)
> Thanks for telling us. Was beginning to wonder if it was just OUR code ;)
>
> Mike Allen, 4CheapDomains.Net
> [EMAIL PROTECTED]
> http://www.4CheapDomains.Net
>
> ----- Original Message -----
> From: ST
> To: [EMAIL PROTECTED]
> Sent: Thursday, April 25, 2002 11:44 PM
> Subject: RE: verify_order
>
>
> Hi,
>
> I noticed this as well. It's just for .US. I'm looking at XML_Client.pm
> right now, trying to pin it down. Right now, for .US, the only required
> fields appear to be Tech Postal Code and Tech State.  What extra
> validation
> does $custom_verify='us' do? Can I just get rid of it?
>
> ST
> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On
> Behalf Of Dev-List
> Sent: Thursday, April 25, 2002 12:57 PM
> To: [EMAIL PROTECTED]
> Subject: verify_order
>
>
> Hi All...
>
>     Just noticed out cgi is not returning errors when we press "Verify
> Order"   should that tell you when cc#'s etc are not correct?  I looked at
> the code and don't see an error ;(
>
> Thanks...
>
> Mike
>

Reply via email to