On 12/2/13 11:39 PM, Mike Hommey wrote:
1. By the way, those type of bugs that show up at different number of
unified sources are existing type of problems waiting to arise when we
add source files, and running non-unified builds doesn't catch them.

A number of the ones I saw you file seemed to do with #defines in .cpp files that then affect other .cpp files.

I would argue that any .cpp file that #defines something and doesn't #undef it shouldn't be unified... Is there any way we can enforce that at compile-time?

-Boris

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to