On Mon, Jan 6, 2014 at 5:04 PM, smaug <[email protected]> wrote: > no, since it is always possible to expand those macros. > However > if (NS_WARN_IF(NS_FAILED(rv)) { > return rv; > } > is super ugly. >
Note that there in a explicit stylistic exception that NS_WARN_IF statements do not require braces. So it's: if (NS_WARN_IF(NS_FAILED(rv))) return rv; Also, I agree that we should get NS_WARN_IF_FAILED. Then it becomes: if (NS_WARN_IF_FAILED(rv)) return rv; which is almost as palatable as NS_ENSURE_SUCCESS(rv, rv); bholley _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
