On Wed, Apr 23, 2014 at 11:52:12AM +1200, Robert O'Callahan wrote: > On Wed, Apr 23, 2014 at 11:48 AM, Mike Hommey <m...@glandium.org> wrote: > > On Tue, Apr 22, 2014 at 07:25:46PM -0400, Trevor Saunders wrote: > > > No, that's just how we choose between #pragma visibility and > > > -fvisibility=hidden > > > > Well, its at least strange given the bugs mentioned in configure were > > supposedly fixed in gcc 4.1, but I wouldn't be at all suprised if > > investigating it finds the tests are wrong. > > They most certainly are. As Benjamin mentioned, we should just remove > them and force pragmas with gcc/clang, except on mac, where we'd use > -fvisibility=hidden. Want to finish bug 961264? ;)
yeah, should get to it soon. > But the #pragma test is only failing on Mac because the test is wrong, right? very likely yes, though making pragmas work on macmight take more effort and its not really clear it would be any better there. Trev > > Rob > -- > Jtehsauts tshaei dS,o n" Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le > atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o Whhei csha iids teoa > stiheer :p atroa lsyazye,d 'mYaonu,r "sGients uapr,e tfaokreg iyvoeunr, 'm > aotr atnod sgaoy ,h o'mGee.t" uTph eann dt hwea lmka'n? gBoutt uIp > waanndt wyeonut thoo mken.o w
signature.asc
Description: Digital signature
_______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
