On 2014-04-24, 7:24 PM, Mike Hommey wrote:
On Thu, Apr 24, 2014 at 07:03:09PM -0400, Ehsan Akhgari wrote:
On 2014-04-24, 8:31 AM, Henri Sivonen wrote:
However, especially in the context of slimming down our own set of
encoding converters, it's rather demotivating to see that at least on
desktop, we are building ICU encoding converters that we don't use.
See https://bugzilla.mozilla.org/show_bug.cgi?id=944348 .
Please allow me to upset you even further! We build and ship *all* of ICU,
and presumably ship a tiny portion of it. This is at least in part due to
bug 915735, you can go and read the bug to see that I did the best I could
there, given the constraints that I had (not understanding how the magic of
the interaction of ICU and our build system worked, not understanding which
parts of ICU we actually want to use, the performance and code quality
limitations of MSVC's PGO compiler, the fact that increasing the amount of
time we allow our builds to progress is rocket science, etc. None of this
was fun, but please understand that it wasn't like somebody sat down and
decided that it's a great idea to build and ship all of ICU.
I'm still amazed that we allowed ICU to land that way at all. And there
I don't mean your changes, which don't particularly change how much of
ICU is built.
I'm pretty sure my changes did make things worse, since they effectively
made the linker unable to eliminate anything assuming that it did back
when ICU was built into mozjs.dll...
Cheers,
Ehsan
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
