It looks like the current one should already be as the the AssignASCII
will be inlined into the caller and then the strlen can be inlined as
well.
-Jeff
On Sun, Mar 1, 2015 at 7:04 PM, smaug <sm...@welho.com> wrote:
> On 03/02/2015 01:11 AM, Xidorn Quan wrote:
>>
>> On Mon, Mar 2, 2015 at 9:50 AM, Boris Zbarsky <bzbar...@mit.edu> wrote:
>>
>>> On 3/1/15 5:04 PM, Xidorn Quan wrote:
>>>
>>>> Hence I think we should remove this method. All callees should use
>>>> either
>>>> AssignLiteral(MOZ_UTF16("some string")), or, if don't want to bloat the
>>>> binary, explicitly use AssignASCII("some string").
>>>>
>>>
>>> The latter requires an strlen() that AssignLiteral optimizes out, right?
>>>
>>
>> Yes, so we can add another overload to AssignASCII which does this
>> optimization
>
> How would you do that?
>
>> with less misleading.
>>
>> - Xidorn
>>
>
> _______________________________________________
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
