On 06/04/2015 01:07 PM, David Rajchenbach-Teller wrote:
Part of my world domination plans are to turn warnings into something
that causes test to actually fail (see bug 1080457 & co). Would you like
to join forces?
Turning warnings into failures sounds odd (but bug 1080457 seems to be actually
something different).
Warnings aren't anything which should cause tests to fail.
Warnings, especially those generated by NS_ENSURE_* macros are things which are
super
useful for debugging - they often point rather exactly where to start looking
for an issue.
And since there is NS_ENSURE_*, there isn't necessarily any problem or bug,
just an unusual state, which
is then handled by the NS_ENSURE_* macro.
-Olli
Cheers,
David
On 04/06/15 03:14, Eric Rahm wrote:
We emit a *lot* of runtime warnings when running debug tests. I inadvertently
triggered a max log size failure during a landing this week which encouraged me
to take a look at what all is being logged, and what I found was a ton of
warnings (sometimes accompanied by stack traces). Most of these should probably
be removed (of course if they're real issues they should be fixed, but judging
by the frequency most are probably non-issues).
I'm currently cleaning up some of these, but if you happen to see something in
the following list and are feeling proactive I would appreciate the help.
There's even a meta bug for tracking these:
https://bugzilla.mozilla.org/show_bug.cgi?id=765224
I generated this list by grabbing the logs for a recent m-c linux64 debug run,
normalizing out PIDs and timestamps and then doing some sort/uniq-fu to get
counts of unique lines.
This is roughly the top 40 offenders:
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
