On Tue, Jul 7, 2015 at 3:59 PM, Eric Rahm <er...@mozilla.com> wrote: > I'm not a huge fan of the 'aFoo' style, but I am a huge fan of > consistency. So if we want to change the style guide we should update our > codebase, and I don't think we can reasonably do that automatically without > introducing shadowing issues. >
MSVC 2013 (which I believe is our main windows compiler right now) will error during compilation if such a shadowing issue arises. Thus, if the code compiles there, `aFoo`->`foo` is safe. I would be very surprised if GCC or Clang didn't have an equivalent option. > Additionally I don't spend 50% of my time reviewing, so I'd say my opinion > here (meh to aFoo) is less important. It's not an undue burden for me to > include an aPrefix and if we have static analysis to check for it that > would make it even less of an issue. > It can be a burden on the hundreds of devs who have to read and understand the code in order to write more code. With the exception of a couple people, review is not the bottleneck. The opinions of a few over-harried reviewers should not hold undue sway over the many many devs writing code. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
