On 02/08/15 04:55 AM, smaug wrote: > A new type of error 'auto' seems to cause, now seen on m-i, is > auto foo = new SomeRefCountedFoo(); > > That hides that foo is a raw pointer but we should be using nsRefPtr. > > So please, consider again when about to use auto. It usually doesn't > make the code easier to read, > and it occasionally just leads to errors. In this case it clearly made > the code harder to read so that > whoever reviewed that patch didn't catch the issue.
Shouldn't we, instead, ensure that SomeRefCountedFoo() returns a nsRefPtr? Hub _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
