MozReview, specifically, Review Board, has a number of bugs related to
interdiffs[1]. Many of these bugs are related to Review Board's
algorithms to filter out changes caused by rebases (as opposed to
intentional updates to commits). Both the MozReview and the Review Board
teams have done some investigation and are working on fixes, but they
are complex problems, and it may take a fair amount of work to get
reliably filtered interdiffs.

Thus, since it's preferable to include irrelevant changes over hiding
relevant changes, we have disabled rebase filtering altogether, for now
at least[2]. I wanted to announce this to alert people who've
experienced these problems, and to explain why you might suddenly see
unrelated changes (caused by rebasing) being highlighted in an interdiff.


Mark


[1] These are being collected under bug 1255654. There are likely
dupes/related bugs, but we haven't dug deep enough into all of them to
be sure.
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1258029

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to