On Fri, Apr 29, 2016 at 1:46 PM, Chris Peterson <cpeter...@mozilla.com> wrote:
> On 4/29/16 5:53 AM, Nathan Froyd wrote: > >> This is a noble goal, but there is an enormous amount of code that >> would need to be modified to make this feasible. Perhaps if you >> exempted nsresult from MOZ_MUST_USE types. >> > > In theory, nsresult seems like an important type to check. > > That said, I once tried building Gecko with `#define NS_IMETHOD > MOZ_WARN_UNUSED_RESULT NS_IMETHOD_(nsresult)`. There were over 10,000 > warnings for XPCOM method callers not checking nsresult return values, so > this approach does not seem practical. :( nsresult is required in a lot of method signatures (thanks XPIDL!) which makes it often not an important type to check. - Kyle _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
