On 31/05/2016 09:40, Nicholas Nethercote wrote:
On Tue, May 31, 2016 at 5:06 PM, Chris Peterson <[email protected]> wrote:
#2 is unannotated MOZ_CRASH() calls, i.e. there is no string argument
given. These are mostly OOMs, though there are a few others in there.
These ones should be annotated so they show up separately.
MOZ_CRASH()'s explanation string parameter is optional. Should it be
required? There are 998 calls in mozilla-central to MOZ_CRASH() without an
argument, so annotating all of these won't happen overnight.
Doesn't seem worthwhile. Annotating the one in NS_ABORT_OOM() will
cover the vast majority of the cases, and annotating (or fixing) a
handful more cases will get us almost all of the others.
We could do a find/replace of no-arg calls to a new macro that uses
MOZ_CRASH with a boilerplate message, and make the argument non-optional
for new uses of MOZ_CRASH? That would avoid the problem for new
MOZ_CRASH() additions, which seems like it would be wise so the problem
doesn't get worse? Or is it not worth even that?
~ Gijs
_______________________________________________
dev-platform mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-platform
