Things that would help me help with this endeavour: 1: A bug to file patches against 2: A method for detecting if our fix actually fixes the problem
I presume a skeleton of what we're looking for is: 1) Use DXR/ls -r/whatever to find the test file in the tree 2) On the line number(s) mentioned, replace the existing use of a CPOW with something better. This may involve writing things in terms of ContentTask (see documentation here[X]), or by simply finding a non-CPOW-using alternative (like using browser.webNavigation.sessionHistory instead of browser.sessionHistory) 3) Run the test to make sure it still passes using ./mach test path/to/test.js 4) Write an informative commit message linking back to bug XXXX 5) Based on what kind of test it is, send it to try to make sure it isn't broken on other platforms 6) <INSERT VALIDATION OF CPOW REMOVAL STEP HERE> 7) Get the patch reviewed on bug XXXX Is this correct? :chutten On Wed, Oct 19, 2016 at 5:00 AM, Gabriele Svelto <gsve...@mozilla.com> wrote: > Hi Blake, > > On 19/10/2016 00:28, Blake Kaplan wrote: > > I've been seeing a pattern of "unsafe" CPOWs causing our browser-chrome > > mochitests to go intermittently orange. Generally, it seems that a test > > randomly turns orange, gets starred and ignored until RyanVM or another > one > > of our sheriffs gets tired of seeing it and needinfos somebody in the > hopes > > of fixing it. > > I remember we did a big push in the War on Orange maybe three (or four?) > years ago. We could do it again; calling out to everybody to take > intermittent tests in the modules they're familiar with and start fixing > them. Personally I'd happily dedicate a chunk of my time to doing it for > a couple of weeks; having to re-trigger stuff every single time I make a > try run drives me nuts. > > Gabriele > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
