On Sun, Dec 25, 2016 at 05:35:40PM -0800, [email protected] wrote: > While preparing for the transition to the new localization framework, > I noticed[0] that we use a large number of loosely overlapping > build-time variables to indicate different combinations of widgets, > platforms and GUIs. > > It would be awesome if we could bring some consistency to that. In > particular, I'd appreciate if we could decide if we want to go for > XP_GNOME, or MOZ_WIDGET_GTK=2|3 or MOZ_WIDGET_TOOLKIT=gtk2|gtk3.
XP_GNOME comes to a surprise to me. But then it's only used in one place, and defined in the same place, so it's a local thing... As for MOZ_WIDGET_GTK vs. MOZ_WIDGET_TOOLKIT, there are 2 essentially because you can't do things like "#if MOZ_WIDGET_TOOLKIT == foo" in C++ code, although, come to think of it, we could have a MOZ_WIDGET(foo) macro... Also note that generally speaking, there is a difference between the platform (e.g. XP_WIN, XP_LINUX, etc.) and the widget (MOZ_WIDGET_TOOLKIT). For example, while probably not true anymore, you could build with the Gtk toolkit for Mac. So, generally speaking, there is a need to differentiate both. Mike _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
