On Wed, May 10, 2017 at 10:27 AM, Karl Tomlinson <mozn...@karlt.net> wrote:
> > Or is NotNull really too awkward IRL? > I wrote NotNull.h, and I've used it in various places. I'm ambivalent about it. It does make things clear, but it also is a bit annoying to use. The code tends to end up with WrapNotNull() and get() calls littered throughout. It also doesn't currently work with UniquePtr. The two big comments in mfbt/NotNull.h have some discussion about use cases for references and pointers and NotNull that is relevant to this thread: https://dxr.mozilla.org/mozilla-central/rev/b21b974d60d3075ae24f6fb1bae75d0f122f28fc/mfbt/NotNull.h#10-99 I also fiddled around with a MaybeNull type, to explicitly mark pointers that are nullable, but it was more complex and less obviously useful than NotNull, so I gave up on it. Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
