On Mon, May 22, 2017 at 4:45 PM, Karl Tomlinson <mozn...@karlt.net> wrote:
> Andrew McCreight writes: > > > On Fri, May 19, 2017 at 7:38 PM, Nicholas Nethercote < > n.netherc...@gmail.com > >> wrote: > > > >> There's also a pre-processor constant that we define in > Valgrind/ASAN/etc. > >> builds that you can check in order to free more stuff than you otherwise > >> would. But I can't for the life of me remember what it's called :( > >> > > > > NS_FREE_PERMANENT_DATA. > > I understand the need to clean up objects for > NS_BUILD_REFCNT_LOGGING, but how important is this for objects not > tracked with NS_BUILD_REFCNT_LOGGING, but only MOZ_VALGRIND and/or > MOZ_ASAN? > > I thought I'd seen enough unfreed allocations that can be > referenced from a root in static storage, that I assumed that > valgrind and ASAN ignored these allocations in their leak report. > That is correct for LSan. I don't know how Valgrind reports leaks. Is the inclusion of MOZ_VALGRIND and MOZ_ASAN in the value of > NS_FREE_PERMANENT_DATA merely to make leak detection easier for > valgrind and ASAN, or will such allocations be reported as leaks > by these tools? > It will let you clean up things that are not referred to by static storage, and change behavior in other ways that are needed for leak checking. For instance, we do our shutdown CCs when it is defined, and disables the timeout for shutting down a child process. _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
