On 08/30/2017 09:03 PM, Eric Rahm wrote:
Okay sounds like there's agreement on a).
Indeed. I have edited the Style Guide to reflect this.
Thanks everyone!
-e
On Tue, Aug 29, 2017 at 11:40 PM, Martin Thomson <[email protected]
<mailto:[email protected]>> wrote:
On Wed, Aug 30, 2017 at 12:07 PM, L. David Baron
<[email protected] <mailto:[email protected]>> wrote:
> I think I do this because (b) has the disadvantage that more code
> changes require touching additional lines, which is both changes
> blame and is extra work (although it's not extra work if we're using
> clang-format tree-wide). Option (b) is also more likely to lead to
> overly long lines that require wrapping.
NSS had a lot of option (b) and we agreed that it was bad for these
reasons. You also have to agree not to do this, another thing that
NSS was infested with:
nsresult ShortFunction(with arg, and another);
void Function2 (HasOnlyOne* arg);
Does clang-format even *do* this? AlignConsecutiveDeclarations is the
closest I could find to a directive that would do this sort of crazy
alignment, but that seems more likely to govern my example than
argument lists. For the record, we should not enable that either.
_______________________________________________
dev-platform mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-platform
