On 6/6/18 11:48 AM, Mark Côté wrote:
On Wednesday, 6 June 2018 11:18:43 UTC-4, Boris Zbarsky wrote:
* Stacked revisions. If you have a stack of revisions, that is, two or more
revisions with parent-child relationships, Lando cannot land them all at once.
Does Differential support this case now? I recall there were problems
around it at one point, but maybe they were fixed?
Differential has always supported this, just not quite as smoothly as
MozReview. See
http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#series-of-commits.
We are still evaluating ways to make this smoother. Our ideal situation is
to get this into upstream Phabricator; we're currently discussing this with
Phacility. Failing that, we have a few options for tools we can build
ourselves. More to come onthis.
That sounds like a no. I suspect a disconnect here:
I think bz is asking about mozReview's ability to handle multiple
commits in a single review (and handle updates in both dimensions). This
fits the hg evolve model well, and was AFAIK a unique workflow of mozReview.
That seems different from the ability to review a set of commits not
based straight off of central (e.g. on top of a local patch set under
different review). Even github allows that, but hardly scales past 2.
From https://bugzilla.mozilla.org/show_bug.cgi?id=1457525#c3 it sounds
like all commits are squashed when pushed for review, and that
Differential just can't handle this complexity.
I for one will dearly miss mozReview's "evolve" design around reviewing
a whole set of broken-down commits, having done mozreviews with ~3-106
(!) commits in the past.
.: Jan-Ivar :.
_______________________________________________
dev-platform mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-platform
