On Fri, Dec 7, 2018 at 11:36 AM Sylvestre Ledru <sle...@mozilla.com> wrote: > In the meantime, we will be running a bot weekly to reformat the > mistakes and add the changeset into the ignore lists. > But in the long run this won’t be sustainable, so once we gain > confidence that a good number of developers have successfully integrated > clang-format into their local workflow, we will look into enabling a > Mercurial hook on hg.mozilla.org to reject misformatted code upon push > time. That will be the ultimate solution to help ensure that our code > will be properly formatted at all times.
Have you considered something like running clang-format automatically during landing (i.e. as part of what Lando does to the patch)? That seems like it would achieve the best of both worlds, by not placing any requirements on what developers do locally, while also ensuring the tree is always properly formatted without cleanup commits. Cheers, Botond _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
