This makes sense, thanks!
On Tue, Dec 11, 2018 at 6:45 AM Ted Mielczarek <t...@mielczarek.org> wrote:
>
> On Mon, Dec 10, 2018, at 8:29 PM, Kartikaya Gupta wrote:
> > This is sort of tangential, but what's the linking story currently?
> > Are we still linking with MSVC, or with lld?
>
>
> We're using lld-link for Windows builds in CI:
> https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/browser/config/mozconfigs/win64/common-opt#23
> https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/build/win64/mozconfig.vs-latest#3
> https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/build/mozconfig.lld-link#8
>
> > I discovered recently
> > that the rust toolchain we use in automation on windows tries to use
> > link.exe for linking.
>
> We use binaries repackaged from Rust releases, so this is just the way rustc
> works on Windows. We do pass the linker we use for non-Windows platforms down
> to cargo in the Firefox build:
> https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/config/rules.mk#1009
>
> and we pass down a host linker on Win32 builds because we use a 64-bit rustc:
> https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/build/moz.configure/rust.configure#343
> https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/.cargo/config.in#23
>
> > I'm in the process of trying to get standalone
> > webrender tests running on taskcluster/windows, and to do that I had
> > to ensure that the worker has MSVC installed (I couldn't get it to
> > play nice with lld-link.exe from the clang-cl toolchain, but maybe I
> > didn't do it right). If we remove support for MSVC generally, are we
> > going to remove the MSVC tarballs from tooltool as well?
>
> Due to some other reasons we will still require the MSVC tarballs for
> building in CI. We need the standard library headers + libs as well as the
> Windows SDK even when using clang-cl.
>
> -Ted
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
