Yeah, I did consider "non-e10s" for awhile and maybe it is the better choice. But here are my counter arguments:
1) One of the goals of this change is to de-clutter the treeherder UI. Using an 8 character symbol suffix runs counter to that goal (even if it is still less cluttered overall). 2) People who use "e10s" in their |mach try fuzzy| queries out of muscle memory (or in saved presets) will accidentally select the exact opposite of what they want. 3) For new contributors "e10s" is a code word anyway. It's just now they need to learn "fc" instead of "e10s". None of those are terribly compelling, but it's still enough to make me prefer "-fc". On Tue, Apr 9, 2019 at 3:34 PM Sylvestre Ledru <sle...@mozilla.com> wrote: > > Le 09/04/2019 à 21:26, Andrew Halberstadt a écrit : > > Hi everyone, > > > > Almost all of our tasks in CI now run with e10s enabled, we only run > > non-e10s > > with Fennec and Linux32. Yet the "default" state in terms of our CI, is > > still non- > > e10s. You can see this by the presence of "-e10s" suffixes in task labels > > and > > treeherder symbols. > > > > To better reflect reality, I'd like to switch things around such that > "e10s" > > becomes the default state and non-e10s tasks are the ones that need > special > > labeling. In bug 1541527 > > <https://bugzilla.mozilla.org/show_bug.cgi?id=1541527> I have a patch > that > > removes all "-e10s" suffixes from > > treeherder symbols and task labels, and adds a new "-fc" suffix to > non-e10s > > tasks. > Thanks for doing that! > > This change could potentially cause disruptions to things like saved > |mach > > try > > fuzzy| presets or ActiveData queries that depend on the task label. *If > you > > can* > > *think of any other possible reasons to hold off from landing please let > me* > > *know!* I'll wait a week for comment. > > > > Why -fc? > What about "non-e10s"? I think code names aren't great for new comers > and just make their life harder. > > Sylvestre > > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
