On July 25, 2019 the Engineering Workflow team will enable a hook to
require an explanation string for direct (non-Lando) pushes to autoland,
mozilla-inbound and mozilla-central repositories. The intent of this change
is to shift usage to our automated infrastructure, and better understand
any remaining barriers to its adoption.
On average, 85% of mozilla-central commits reviewed in Phabricator are
landed by Lando. That indicates that Lando is working well for most
engineers, and we’d like to drive this number closer to 100% to unlock new
workflow capabilities such as running static analyzers, linters, and code
formatting tools through this pipeline. This will also reduce operational
risk by landing reviewed code automatically. However, we also want to avoid
creating roadblocks in any edge-case situations where the tooling fails -
so we’re keeping a manual fallback in place for use in exceptional
circumstances.
What is an acceptable reason to push directly to autoland, mozilla-inbound
or mozilla-central?
In brief, if something in Lando is actively preventing you from getting
work done, you may push directly to hg.mozilla.org. This includes prolonged
outages, specific breakage or a time-sensitive emergency. The other
possible reason for pushing directly is that the patches you are pushing
aren’t supported by Lando (for instance a large amount of vendored code).
You will be asked to provide a brief explanation of why you are pushing
directly as part of the “{hg,git} push” command. (To override, in your top
commit, include the literal string, "MANUAL PUSH:" followed by a sentence
of justification.)
Note that we will be logging all manual pushes both to ensure this
functionality is reserved for exceptional circumstances, and to identify
problems that are blocking people from using Lando. Six weeks after the
hook is enabled, we’ll provide a summary of the issues identified and
relevant bug reports to this list.
What about checkin-needed?
We will be using a very similar process to Bugzilla, in which users can use
a #checkin-needed tag in Phabricator to request that a sheriff or other
user with appropriate privileges land their patches. Follow bug 1514807
<https://bugzilla.mozilla.org/show_bug.cgi?id=1514807> for updates on this
process or read the checkin-needed documentation
<https://wiki.mozilla.org/Sheriffing/How_To/Landing_checkin-needed_patches>.
If you have questions, please reach out in the #phabricator channel in
slack or irc.
Kim
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
