Thank yo very much.

I thought I sent out an e-mail stating that I would be working on filings the warnings coming from files in /editor/ directory in a next month or so after cleaning up my patches that I have been working on the last few weeks..
(But I could not find the e-mail. Hmm.)

I will study your bugzillas and I will file missed situations, if any.

Thank you again!

Chiaki

On 2022/05/27 11:28, Masayuki Nakano wrote:
On 22/04/22 16:22, ISHIKAWA,chiaki wrote:
10 top most warnings coming from /libeditor/ during local mochitest
run of debug version of TB.
(TB has to create messages and editing is done actually to underlying HTML
document, BTW.)

   ========================================
   Firstly, warnings under /libeditor/
   ========================================

4982: Main Thread] WARNING: HTMLEditor::GetAbsolutelyPositionedSelectionContainer() reached <html> element: file /NEW-SSD/NREF-COMM-CENTRAL/mozilla/editor/libeditor/HTMLAbsPositionEditor.cpp:95 525: Main Thread] WARNING: mozInlineSpellChecker::Cleanup() failed, but ignored: 'NS_SUCCEEDED(rvIgnored)', file /NEW-SSD/NREF-COMM-CENTRAL/mozilla/editor/libeditor/EditorBase.cpp:609 396: Main Thread] WARNING: '!aNode', file /NEW-SSD/NREF-COMM-CENTRAL/mozilla/editor/libeditor/EditorBase.cpp:3268 48: Main Thread] WARNING: Perhaps, <br> element position has been moved to different point by mutation observer: 'currentPoint == pointToInsert', file /NEW-SSD/NREF-COMM-CENTRAL/mozilla/editor/libeditor/HTMLEditSubActionHandler.cpp:1252 41: Main Thread] WARNING: '!mSelection', file /NEW-SSD/NREF-COMM-CENTRAL/mozilla/editor/libeditor/EditorBase.cpp:6052 40: Main Thread] WARNING: '!editableContent', file /NEW-SSD/NREF-COMM-CENTRAL/mozilla/editor/libeditor/HTMLEditUtils.h:764 15: Main Thread] WARNING: TopLevelEditSubActionData::AddRangeToChangedRange() failed: 'NS_SUCCEEDED(rv)', file /NEW-SSD/NREF-COMM-CENTRAL/mozilla/editor/libeditor/EditorBase.cpp:6412 15: Main Thread] WARNING: TopLevelEditSubActionData::AddNodeToChangedRange() failed, but ignored: 'NS_SUCCEEDED(rvIgnored)', file /NEW-SSD/NREF-COMM-CENTRAL/mozilla/editor/libeditor/EditorBase.cpp:6541 15: Main Thread] WARNING: HTMLEditor::DeleteNodeWithTransaction() failed: 'NS_SUCCEEDED(rv)', file /NEW-SSD/NREF-COMM-CENTRAL/mozilla/editor/libeditor/HTMLEditSubActionHandler.cpp:963

Hi, I investigated (and already fixed) some warnings related to editing. As far as I've investigated, all of the investigated ones detected bugs. So, just silence the warnings is not good. At least file a bug for individual warning.

  * Bug 1766764 - WARNING: Failed to remove transaction listener from
    the editor: 'removedTransactionListener', file
    /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:448
    <https://bugzilla.mozilla.org/show_bug.cgi?id=1766764>
  * Bug 1766956 - WARNING:
    nsRange::CompareBoundaryPoints(Range_Binding::START_TO_START)
    failed: file
    /builds/worker/checkouts/gecko/editor/libeditor/SelectionState.cpp:141
    <https://bugzilla.mozilla.org/show_bug.cgi?id=1766956>
  * Bug 1767386 - WARNING: '!document', file
    /builds/worker/checkouts/gecko/editor/libeditor/CSSEditUtils.cpp:562
    <https://bugzilla.mozilla.org/show_bug.cgi?id=1767386>
  * Bug 1767558 - WARNING: '!mLastFocusedWindow', file
    /builds/worker/checkouts/gecko/widget/gtk/IMContextWrapper.cpp:3253
    <https://bugzilla.mozilla.org/show_bug.cgi?id=1767558>
  * Bug 1726297 - `ContentEventHandler` shouldn't try to get text
    frame from white-space only text nodes
    <https://bugzilla.mozilla.org/show_bug.cgi?id=1726297>
  * Bug 1726298 - `ContentEventHandler` should guess caret rect from
    parent frames when there is no text
    <https://bugzilla.mozilla.org/show_bug.cgi?id=1726298>

--
Masayuki Nakano <[email protected]>
Working on DOM, Events, editor and IME handling for Gecko

--
You received this message because you are subscribed to the Google Groups "[email protected]" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/565efa95-b4ee-2e86-c8a7-ae3161f39eb9%40d-toybox.com <https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/565efa95-b4ee-2e86-c8a7-ae3161f39eb9%40d-toybox.com?utm_medium=email&utm_source=footer>.


--
You received this message because you are subscribed to the Google Groups 
"[email protected]" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/055dcf3a-a03d-b8dd-b7bb-47b19d73fd93%40yk.rim.or.jp.

Reply via email to