Hi , [email protected]
I found a bug in function NSS_CMSSignedData_GetSignerInfo, sigd->signerInfos
not judged !NULL before use. It cause core dump.
NSSCMSSignerInfo *
NSS_CMSSignedData_GetSignerInfo(NSSCMSSignedData *sigd, int i)
{
if (!sigd) {
PORT_SetError(SEC_ERROR_INVALID_ARGS);
return NULL;
}
return sigd->signerInfos[i];
}
Signed-off-by: zhujianwei7 <[email protected]>
---
diff -uNr nss/lib/smime/cmssigdata.c nss.fix/lib/smime/cmssigdata.c
--- nss/lib/smime/cmssigdata.c 2018-12-01 06:41:31.000000000 +0800
+++ nss.fix/lib/smime/cmssigdata.c 2020-04-08 08:20:28.931050077 +0800
@@ -476,7 +476,7 @@
NSSCMSSignerInfo *
NSS_CMSSignedData_GetSignerInfo(NSSCMSSignedData *sigd, int i)
{
- if (!sigd) {
+ if (!sigd || !sigd->signerInfos) {
PORT_SetError(SEC_ERROR_INVALID_ARGS);
return NULL;
}
_______________________________________________
dev-security mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-security
