My main issue with cargo features is that they would pollute all the Cargo.tomls in the dependency tree between servo and devices, and if another dependency is added (even amongst these crates) it would have to be added, or else we may get confusing compile errors.
It would be nice if you can "drop in" features from above without requiring daisy chaining, but AFAICT that's not always doable. It is possible currently to do `cargo build --features net/devices/nameoffeature` without polluting cargo.tomls, but IIRC this isn't always supposed to work (since all the other dependency paths do not have it enabled). If this turns out to be working reliably I'd prefer to do this, though it may unexpectedly break in the future. -Manish Goregaokar On Tue, May 31, 2016 at 8:04 PM, Jack Moffitt <j...@metajack.im> wrote: > > Doing it via Cargo features sounds like the better option to me. I'm fine > > with enabling building Servo without bluetooth support. > > +1. We've had environment variable hacks before, and while convenient, > we usually end up regretting and removing them. > > jack. > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
