Given that we've already done the deed and merged the crates, I think we should hold off on resplitting them until the stylo integration is more mature. We may find other ways to achieve additional type safety with tight coupling between generate bindings and other style code (like the ElementData stuff we have now), and I wouldn't want crate separation to stand in the way of that. We can revisit this once development slows down and the tradeoffs are clearer.
If I understand correctly, the cost here is rebuilding the entire style crate whenever the bindings change. I think that cost is probably acceptable for now. On Thu, Dec 15, 2016 at 11:46 AM, Manish Goregaokar <manishsm...@gmail.com> wrote: > I was actually intending to expand that set as necessary, a lot of the > owned and arc types could use this trick too. A lot of this was held back > on the Rust compiler losing inline drop flags (which happened recently). > > > I'm okay with splitting it again, but would prefer to avoid as much as > possible :) > > -Manish Goregaokar > > On Thu, Dec 15, 2016 at 12:50 AM, Xidorn Quan <m...@upsuper.org> wrote: > > > Oh, I see what did you mean. ElementData and AtomicRefCell would be a > > problem. I don't see anything else, though. > > > > - Xidorn > > > > On Thu, Dec 15, 2016, at 05:29 PM, Manish Goregaokar wrote: > > > The sugar stuff is just helpers. The crossover happens in the bindings > > > file > > > itself, where &ServoOpaqueType gets replaced with &RealType, etc. > > > > > > On Dec 14, 2016 5:13 PM, "Xidorn Quan" <m...@upsuper.org> wrote: > > > > > > > On Thu, Dec 15, 2016, at 12:01 PM, Manish Goregaokar wrote: > > > > > They used to be a different crate. I merged them so that we can do > > > > > replacements with safer wrappers and have fewer coherence issues. > > > > > > > > It doesn't seem to me the safer wrappers (I suppose the ones in > > > > gecko_bindings/sugar?) needs the bindings to stay in the style > > > > component. We can still leave gecko mod in style component, and just > > > > split out the bindings mods. That shouldn't cause much trouble I > > > > suppose. > > > > > > > > > Perhaps we can make triggering local build time bindgen regen more > > > > > explicit? > > > > > > > > You mean, probably not listing that many files in > > > > cargo:rerun-if-changed? That probably works I guess. > > > > > > > > - Xidorn > > > > _______________________________________________ > > > > dev-servo mailing list > > > > dev-servo@lists.mozilla.org > > > > https://lists.mozilla.org/listinfo/dev-servo > > > > > > > _______________________________________________ > > > dev-servo mailing list > > > dev-servo@lists.mozilla.org > > > https://lists.mozilla.org/listinfo/dev-servo > > _______________________________________________ > > dev-servo mailing list > > dev-servo@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-servo > > > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
