I pushed a fix, please rebase your pull request to master to pull it in.
Thanks,
-Manish Goregaokar
On Wed, Dec 5, 2018 at 10:08 PM Avanthikaa Ravichandran <aravi...@ncsu.edu>
wrote:
> We pushed the final changes in the code and we have the same issue still.
> On running with backtrace, I got the following output:
>
> RUST_BACKTRACE=1 ./target/debug/constant_source
> thread 'AudioRenderThread' panicked at 'index 128 out of range for slice
> of length 0', libcore/slice/mod.rs:1932:5
> note: Some details are omitted, run with `RUST_BACKTRACE=full` for a
> verbose backtrace.
> stack backtrace:
> 0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
> at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
> 1: std::sys_common::backtrace::print
> at libstd/sys_common/backtrace.rs:71
> at libstd/sys_common/backtrace.rs:59
> 2: std::panicking::default_hook::{{closure}}
> at libstd/panicking.rs:211
> 3: std::panicking::default_hook
> at libstd/panicking.rs:227
> 4: std::panicking::rust_panic_with_hook
> at libstd/panicking.rs:477
> 5: std::panicking::continue_panic_fmt
> at libstd/panicking.rs:391
> 6: rust_begin_unwind
> at libstd/panicking.rs:326
> 7: core::panicking::panic_fmt
> at libcore/panicking.rs:77
> 8: core::slice::slice_index_len_fail
> at libcore/slice/mod.rs:1932
> 9: <core::ops::range::Range<usize> as
> core::slice::SliceIndex<[T]>>::index
> at libcore/slice/mod.rs:2097
> 10: core::slice::<impl core::ops::index::Index<I> for [T]>::index
> at libcore/slice/mod.rs:1914
> 11: <alloc::vec::Vec<T> as core::ops::index::Index<I>>::index
> at liballoc/vec.rs:1725
> 12: servo_media_audio::block::Block::data_chan
> at audio/src/block.rs:166
> 13: servo_media_audio::param::Param::update
> at audio/src/param.rs:100
> 14: servo_media_audio::gain_node::GainNode::update_parameters
> at audio/src/gain_node.rs:34
> 15: <servo_media_audio::gain_node::GainNode as
> servo_media_audio::node::AudioNodeEngine>::process
> at audio/src/gain_node.rs:55
> 16: servo_media_audio::graph::AudioGraph::process
> at audio/src/graph.rs:436
> 17: <servo_media_audio::render_thread::AudioRenderThread<S>>::process
> at ./audio/src/render_thread.rs:226
> 18: <servo_media_audio::render_thread::AudioRenderThread<S>>::event_loop
> at ./audio/src/render_thread.rs:312
> 19: <servo_media_audio::render_thread::AudioRenderThread<S>>::start
> at ./audio/src/render_thread.rs:159
> 20: <servo_media_audio::context::AudioContext<B>>::new::{{closure}}
> at ./audio/src/context.rs:137
> thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value:
> RecvError', libcore/result.rs:1009:5
> stack backtrace:
> 0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
> at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
> 1: std::sys_common::backtrace::print
> at libstd/sys_common/backtrace.rs:71
> at libstd/sys_common/backtrace.rs:59
> 2: std::panicking::default_hook::{{closure}}
> at libstd/panicking.rs:211
> 3: std::panicking::default_hook
> at libstd/panicking.rs:227
> 4: std::panicking::rust_panic_with_hook
> at libstd/panicking.rs:477
> 5: std::panicking::continue_panic_fmt
> at libstd/panicking.rs:391
> 6: rust_begin_unwind
> at libstd/panicking.rs:326
> 7: core::panicking::panic_fmt
> at libcore/panicking.rs:77
> 8: core::result::unwrap_failed
> at libcore/macros.rs:26
> 9: <core::result::Result<T, E>>::unwrap
> at libcore/result.rs:808
> 10: <servo_media_audio::context::AudioContext<B>>::close
> at ./audio/src/macros.rs:24
> 11: constant_source::run_example
> at examples/constant_source.rs:82
> 12: constant_source::main
> at examples/constant_source.rs:88
> 13: std::rt::lang_start::{{closure}}
> at libstd/rt.rs:74
> 14: std::panicking::try::do_call
> at libstd/rt.rs:59
> at libstd/panicking.rs:310
> 15: __rust_maybe_catch_panic
> at libpanic_unwind/lib.rs:103
> 16: std::rt::lang_start_internal
> at libstd/panicking.rs:289
> at libstd/panic.rs:392
> at libstd/rt.rs:58
> 17: std::rt::lang_start
> at libstd/rt.rs:74
> 18: main
> 19: __libc_start_main
> 20: _start
>
>
> The GitHub issue I referred to earlier is :
> https://github.com/servo/media/pull/122 <
> https://github.com/servo/media/pull/122>
> Please let me know what we can do to fix it. I also want to know if is it
> necessary to send any message to the gain node.
>
> Thank you
>
> > On Nov 30, 2018, at 10:22 AM, Manish Goregaokar <manishsm...@gmail.com>
> wrote:
> >
> > It would be helpful to see what your changes are and what test command
> > you're running (along with a full backtrace, setting RUST_BACKTRACE=1
> will
> > let you get one).
> >
> > I'm unable to get this same error when I test your pull request locally.
> > (Which github issue are you talking about?)
> > -Manish Goregaokar
> >
> >
> > On Fri, Nov 30, 2018 at 6:38 AM Avanthikaa Ravichandran <
> aravi...@ncsu.edu>
> > wrote:
> >
> >> I made changes to the ConstantSourceNode example as suggested in the
> review
> >> for the pull request. However, I am getting the following error while
> >> running the file:
> >>
> >> thread 'AudioRenderThread' panicked at 'index 128 out of range for
> slice of
> >> length 0', libcore/slice/mod.rs:1932:5
> >> note: Run with `RUST_BACKTRACE=1` for a backtrace.
> >> thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value:
> >> RecvError', libcore/result.rs:1009:5
> >>
> >> I'm not sure how to rectify this and the GitHub issue that was opened
> >> doesn't seem to have been resolved yet.
> >>
> >> Thank you
> >> _______________________________________________
> >> dev-servo mailing list
> >> dev-servo@lists.mozilla.org
> >> https://lists.mozilla.org/listinfo/dev-servo
> >>
> > _______________________________________________
> > dev-servo mailing list
> > dev-servo@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-servo
>
> _______________________________________________
> dev-servo mailing list
> dev-servo@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-servo
>
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
