Thanks for that. The build was successful! On running the test specified, we got this "ran 213 tests as expected". So am I right in assuming that the modifications we make to the servo code are correct if these tests run as expected?
And also we are asked to create a new adapter.rs file. I noticed that there is an existing adpater.rs file in https://github.com/servo/devices/tree/master/blurmac/src. The one I am creating should be in https://github.com/servo/devices/tree/master/src (containing similar implementation as bluetooth.rs but using traits) right? Thanks a lot for clarifying all the doubts! Niveditha Shankar On Sun, Mar 24, 2019 at 2:19 PM Josh Bowman-Matthews <j...@joshmatthews.net> wrote: > If you are building on macOS, then you are probably hitting the problem > described in https://github.com/servo/servo/issues/21792. The solution > is to install the XCode 10.2 beta > (https://github.com/servo/servo/issues/21792#issuecomment-459590626). > > Cheers, > Josh > > On 3/23/19 10:47 PM, Niveditha Shankar wrote: > > Thank you for reply! > > We wanted to check the output using the command you suggested. We were > > unable to do so as we could not build the project(main servo repo). We > > followed all the steps mentioned in the read me file. > > We tried multiple times in Mac. But the build never got completed. It got > > stuck and the mac froze each time. > > We did the following, > > 1)brew bundle install --file=etc/taskcluster/macos/Brewfile > > 2)pip install virtualenv > > *3)./mach build --dev * > > > > We are also trying in Windows. As of now we are getting an importError. > > > > It would be great if you could you tell us how to fix the build issue for > > mac. We can then go ahead run the automated tests for bluetooth and check > > the existing output. > > > > Thank you! > > Niveditha Shankar > > > > > > > > On Sat, Mar 23, 2019 at 11:57 AM Josh Bowman-Matthews < > j...@joshmatthews.net> > > wrote: > > > >> These are all good questions! You are correct about the reference to the > >> code that you will be modifying. Servo imports the types from the > >> devices crate in this code: > >> > >> > https://github.com/servo/servo/blob/059ac12c00c4cfac4133b23fc3d81e71b90eb8e2/components/bluetooth/lib.rs#L19-L20 > >> .. That means that references to BluetoothAdapter will need to be > adapted > >> (ha!) to accommodate your changes to that crate; you will want to be > >> familiar with how Rust code uses traits for that: > >> https://doc.rust-lang.org/book/ch17-02-trait-objects.html > >> > >> I can't think of any similar changes you could use as a reference off > >> the top of my head, unfortunately. > >> > >> As for the the behaviour of the code, you can rely on `./mach test-wpt > >> tests/wpt/mozilla/tests/bluetooth/` to run the existing bluetooth > >> automated tests. Ideally there should be no difference in output after > >> your changes. > >> > >> Cheers, > >> Josh > >> > >> On 3/23/19 10:53 AM, Niveditha Shankar wrote: > >>> I have a few more doubts regarding the output: > >>> > >>> 1) What is the existing output for the code we have to work on? > >>> 2) Which file should we execute to obtain the same? > >>> > >>> As we are doing only refactoring, I am guessing there would not be any > >>> change in the output. > >>> Wanted to know against what we should check our code with. > >>> > >>> Thank you! > >>> Niveditha Shankar > >>> > >>> On Sat, Mar 23, 2019 at 12:34 AM Niveditha Shankar <nshan...@ncsu.edu> > >> wrote: > >>>> > >>>> Hello > >>>> Just wanted to make sure that we are working with the correct part of > >> the code, > >>>> To convert the BluetoothAdapter from enum to trait, are we right in > >>>> assuming that we will be working with the following, Line 93-106 in > >>>> https://github.com/servo/devices/blob/master/src/bluetooth.rs. > >>>> > >>>> Could you brief us more on this - "Modify Servo's integration to use > >>>> this new trait" > >>>> > >>>> And also, is there any other similar implementation for this > >>>> conversion that we can refer to? > >>>> > >>>> > >>>> Thank you > >>>> > >>>> Niveditha Shankar > >> _______________________________________________ > >> dev-servo mailing list > >> dev-servo@lists.mozilla.org > >> https://lists.mozilla.org/listinfo/dev-servo > >> > > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
