Hi Josh, I totally understand. We will try to fix it using the examples you have provided for now. Anyways, we will be continuing with the project for our final project so whenever you/your team can validate our implementation, it would help us proceed if we don't fix the issue by then. Thank you for doing the same.
Best, Akhilesh On Sat, Mar 30, 2019 at 11:27 PM Josh Bowman-Matthews <j...@joshmatthews.net> wrote: > On 3/30/19 6:20 PM, Akhilesh Venkatasubramanian wrote: > > Hi Josh, > > > > 1. Yes we are working on the example and have it defined as follows: > > > https://github.com/JHBalaji/media/blob/master/examples/set_value_curve.rs > > > > Can you tell us if the example we have defined is right? We have written > it > > similar to the example you shared with us > > < > https://developer.mozilla.org/en-US/docs/Web/API/AudioParam/setValueCurveAtTime > > > > . > > > > 2. Our implementation of the SetValueCurveAtTime to this point is as > > follows: > > > https://github.com/JHBalaji/media/blob/master/audio/src/param.rs#L419-L439 > > > > As you had mentioned earlier, can you/someone from your team verify if > our > > function definition is right? (Specifically for the linear interpolation > > part, that's where we think the mistake is but not sure how to change it) > > as we are getting a few errors while trying to run the example. > > I cannot guarantee that anybody will review it before Monday, sorry. You > could try looking at an existing implementation in Firefox for reference: > * > > https://searchfox.org/mozilla-central/source/dom/media/webaudio/AudioEventTimeline.h#71-75 > * > > https://searchfox.org/mozilla-central/source/dom/media/webaudio/AudioEventTimeline.cpp#31-53 > > > Error: > > > > Akhileshs-MBP:media akhilesh$ ./target/debug/set_value_curve > > > > thread 'AudioRenderThread' panicked at 'index out of bounds: the len is 9 > > but the index is 9', > > /rustc/94fd0458951a4ff91c03366445f0e2e93b86bd2f/src/libcore/slice/ > mod.rs:2539 > > :10 > > > > note: Run with `RUST_BACKTRACE=1` environment variable to display a > > backtrace. > > > > thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: > > RecvError', src/libcore/result.rs:997:5 > > Running with RUST_BACKTRACE=1 will show you the precise line that is > panicking. I suspect you are not dealing with the case where the > duration has been exceeded. > > > Cheers, > Josh > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
