Re: [dev-servo] println!("Hello from NCSU");

Josh Bowman-Matthews Mon, 22 Apr 2019 07:11:17 -0700

`*values` is dereferencing the Vec value, which produces a slice (&[]).What you need to do instead is produce a new vector of dereferencedFinite values instead: `values.into_iter().map(|v| *v).collect()`


cheers,
Josh


On 4/22/19 2:32 AM, Akhilesh Venkatasubramanian wrote:

Hi Josh,

I tried to run ./mach build --dev and found that there are some problems
with passing the vector of values. I can see from
servo/target/debug/build/script-ca412800c93d1355/out/Bindings/AudioParamBinding.rs:1273:43
the type should be initialized as Vec<Finite<f32>> but there are errors in
the line 202 in this:
https://github.com/Akhilesh1996/servo/blob/master/components/script/dom/audioparam.rs#L196-L202
<https://github.com/Akhilesh1996/servo/blob/master/components/script/dom/audioparam.rs#L196-L202>
while calling the values in the function.

I get the error: expected struct `std::vec::Vec`, found slice
Any idea on how I should be passing on the variables? Or should
the initialization be different?

Thanks,
Akhilesh

On Sun, Apr 21, 2019 at 10:30 PM Akhilesh Venkatasubramanian <
avenk...@ncsu.edu> wrote:

Hi Josh and Manish,

We have started work on the subsequent steps for the project as shown here
<https://github.com/servo/servo/wiki/Implement-missing-WebAudio-automation-student-project>.
I have written code for the 1st step which is ti implement a JS API for
setvaluecurveAtTime and it can be seen as detailed here
<https://github.com/Akhilesh1996/servo/commit/6f5ca57845a2ddea5a8607d17d73d00a7be8e9e8>.
Can you give me some insight if I'm proceeding in the right direction?

And to update the expected test results, I have changed the ERROR in the
metadata .ini file in servo
<https://github.com/Akhilesh1996/servo/tree/6f5ca57845a2ddea5a8607d17d73d00a7be8e9e8>
/tests
<https://github.com/Akhilesh1996/servo/tree/6f5ca57845a2ddea5a8607d17d73d00a7be8e9e8/tests>
/wpt
<https://github.com/Akhilesh1996/servo/tree/6f5ca57845a2ddea5a8607d17d73d00a7be8e9e8/tests/wpt>
/metadata
<https://github.com/Akhilesh1996/servo/tree/6f5ca57845a2ddea5a8607d17d73d00a7be8e9e8/tests/wpt/metadata>
/webaudio
<https://github.com/Akhilesh1996/servo/tree/6f5ca57845a2ddea5a8607d17d73d00a7be8e9e8/tests/wpt/metadata/webaudio>
/the-audio-api
<https://github.com/Akhilesh1996/servo/tree/6f5ca57845a2ddea5a8607d17d73d00a7be8e9e8/tests/wpt/metadata/webaudio/the-audio-api>
/the-audioparam-interface
<https://github.com/Akhilesh1996/servo/tree/6f5ca57845a2ddea5a8607d17d73d00a7be8e9e8/tests/wpt/metadata/webaudio/the-audio-api/the-audioparam-interface>
/audioparam-setValueCurveAtTime.html.ini to PASS, is that all I should
do? Or am I missing something?

Thanks,
Akhilesh

On Sat, Apr 6, 2019 at 5:15 PM Manish Goregaokar <manishsm...@gmail.com>
wrote:

Yes, that is correct. This is mostly a matter of hooking up your new
servo-media additions into the JS DOM apis.
-Manish Goregaokar


On Sat, Apr 6, 2019 at 2:02 PM BAlaji <bjan...@ncsu.edu> wrote:

Hi Josh
Appears to be libgstreamer0.10-dev is outdated in Ubuntu 18.04.

Running the below in terminal fixed the problem. The build succeeds with
rust toolchain being setup as nightly.
sudo apt -y install libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev

We would working on the next issue in the same project  I guess. Going

by

the open issues, I guess we should start on

https://github.com/servo/servo/issues/22897 (JS API for value curves).

Is

this correct?

Thanks
Balaji



From: BAlaji
Sent: Friday, April 5, 2019 6:30 PM
To: dev-servo@lists.mozilla.org
Subject: RE: [dev-servo] println!("Hello from NCSU");

Hi Josh
Unfortunately that didn’t solve the problem but I was able to downgrade

to

OpenSSL 1.0.2 and still cargo was running with issues. So I moved to VM

and

used Xubuntu 16.04 LTS hoping that I should have all the fix in place

but

appears to be the gsteamer issue is plaguing up


warning: /home/j/NCSU/p4/media/Cargo.toml: unused manifest key:
workspace.license
    Compiling gstreamer-sys v0.7.0
error: failed to run custom build command for `gstreamer-sys v0.7.0`
process didn't exit successfully:

`/home/j/NCSU/p4/media/target/debug/build/gstreamer-sys-07f3047be42c0db3/build-script-build`

(exit code: 1)
Requested 'gstreamer-1.0 >= 1.14' but version of GStreamer is 1.8.3


So by reading the last line I fail to understand that I have a version
higher than it required. Any advice?


Thanks
Balaji Janakarajan Hari
Graduate Student - IMSE Program
NC State
linkedin/com/in/jhbalaji
903.600.0091

From: Josh Bowman-Matthews
Sent: Tuesday, April 2, 2019 10:03 AM
To: dev-servo@lists.mozilla.org
Subject: Re: [dev-servo] println!("Hello from NCSU");

Try running `cargo update -p hyper-openssl` and see if that makes any
difference.

On 4/1/19 7:00 PM, Balaji Janakarajan Hari wrote:

Hi Josh
I just moved to xbunutu 18.1.10. Appears to no support for new

OpenSSL of

1.1.1 and greater. Any idea how to fix it?

warning: unused manifest key: workspace.license
     Compiling idna v0.1.5




     Compiling h2 v0.1.13




     Compiling env_logger v0.5.12




     Compiling serde v1.0.80




     Compiling wayland-sys v0.21.4




     Compiling freetype v0.4.0




     Compiling andrew v0.1.4




     Compiling openssl v0.9.24




error: failed to run custom build command for `openssl v0.9.24`




process didn't exit successfully:

`/home/j/NCSU/Spring19/CSC517/media/target/debug/build/openssl-4074b2152e200c57/build-script-build`

(exit code: 101)
--- stderr
thread 'main' panicked at 'Unable to detect OpenSSL version',

/home/j/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-0.9.24/

build.rs:16

:14
note: Run with `RUST_BACKTRACE=1` for a backtrace.
s
warning: build failed, waiting for other jobs to finish...
error: build failed




j@p50:~/NCSU/Spring19/CSC517/media$




Sincerely
Balaji Janakarajan Hari
Graduate Student - IMSE Program
NC State University

linkedin.com/in/jhbalaji

_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo


_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo


_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] println!("Hello from NCSU");

Reply via email to